[GitHub] [flink] zentol commented on a diff in pull request #21150: [hotfix] Replace deprecated kafka-clients methods

[GitBox <gi...@apache.org>]

zentol commented on code in PR #21150:
URL: https://github.com/apache/flink/pull/21150#discussion_r1022556918


##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaConsumerThread.java:
##########
@@ -258,7 +259,7 @@ public void run() {
                 // over
                 if (records == null) {
                     try {
-                        records = consumer.poll(pollTimeout);
+                        records = consumer.poll(Duration.ofMillis(pollTimeout));

Review Comment:
   Note:  This changes the blocking behavior of this call.
   
   https://cwiki.apache.org/confluence/display/KAFKA/KIP-266%3A+Fix+consumer+indefinite+blocking+behavior
   
   I'd like to see a proper ticket for this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org