You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/21 20:46:15 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2106: Added isOpen() to TServerTransport
emmenlau opened a new pull request #2106:
URL: https://github.com/apache/thrift/pull/2106
This PR adds a new method isOpen() to the TServerTransport and implementations TServerSocket and TPipeServer. I've added tests for TServerSocket and tested on a number of platforms. The change is rather small so I did not create a Jira ticket.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2106: Added isOpen() to TServerTransport
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-618835805
CI is all green, merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on issue #2106: Added isOpen() to TServerTransport
Posted by GitBox <gi...@apache.org>.
emmenlau commented on issue #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-618056254
The two errors in Travis CI seem unrelated. Ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2106: Added isOpen() to TServerTransport
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-618691219
Travis errors seem transient, restarted the build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on issue #2106: Added isOpen() to TServerTransport
Posted by GitBox <gi...@apache.org>.
emmenlau commented on issue #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-617959369
Triggering build again, in the hope that CI now works...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org