[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)

["Mike Percy (Code Review)" <ge...@cloudera.org>]

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8858 )

Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................


Patch Set 6: Code-Review+1

(5 comments)

looks good, just nits

http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:

http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@205
PS6, Line 205: work.set_num_tablets(1);
nit: this is the default


http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@238
PS6, Line 238: ait_until_running()
not your fault, but this should be wrapped in NO_FATALS()


http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@248
PS6, Line 248: ASSERT_NE(nullptr, replica.get());
nit: this line is overly defensive because this has already been checked; the contract of GetTabletReplica() is that it returns OK only if it finds the replica.


http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@256
PS6, Line 256: wait_until_running()
NO_FATALS(wait_until_running());


http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@363
PS6, Line 363:  
nit: missing word "the"



-- 
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 05 Jan 2018 23:36:17 +0000
Gerrit-HasComments: Yes