Re: [PR] Check for handoff of upgraded segments (druid)

["github-advanced-security[bot] (via GitHub)" <gi...@apache.org>]

github-advanced-security[bot] commented on code in PR #16162:
URL: https://github.com/apache/druid/pull/16162#discussion_r1574397528


##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/concurrent/ActionsTestTask.java:
##########
@@ -82,7 +82,7 @@
     );
   }
 
-  public Map<SegmentId, SegmentId> getAnnouncedSegmentsToParentSegments()
+  public Map<SegmentId, String> getAnnouncedSegmentsToParentSegments()

Review Comment:
   ## Exposing internal representation
   
   getAnnouncedSegmentsToParentSegments exposes the internal representation stored in field announcedSegmentsToParentSegments. The value may be modified [after this call to getAnnouncedSegmentsToParentSegments](1).
   getAnnouncedSegmentsToParentSegments exposes the internal representation stored in field announcedSegmentsToParentSegments. The value may be modified [after this call to getAnnouncedSegmentsToParentSegments](2).
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/7306)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org