You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/05/28 10:43:12 UTC

Review Request 48007: LENS-1158: Thread names with hive2 build are growing huge

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48007/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1158
    https://issues.apache.org/jira/browse/LENS-1158


Repository: lens


Description
-------

One of the log looks the following:

27 May 2016 04:10:24 [bf1c4dce-f578-4237-8035-b3ba6846319e] [cbfb48cc-e1eb-4b58-9db4-b5b09d15a55d 36caf230-8e8a-4b4d-a0ef-857ec94c0996 7e180c99-0d54-42a0-86e7-d9f88e7e5942 f302b519-9397-4b82-8f50-c1fc93da58d8 097a39a7-b948-4804-ad77-f6beab75a017 1461e1a1-cb77-4c7a-8b20-85969dbcbc9e 656edc21-6050-4174-aa2b-d6ea9d1f71de 276d7420-c9c3-43b2-94f1-e26282b9d24c grizzly-http-server-32] ERROR hive.ql.metadata.Table - Unable to get field from serde:....


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5 

Diff: https://reviews.apache.org/r/48007/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 48007: LENS-1158: Thread names with hive2 build are growing huge

Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48007/#review135631
-----------------------------------------------------------


Ship it!




Ship It!

- Raju Bairishetti


On May 28, 2016, 10:43 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48007/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 10:43 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1158
>     https://issues.apache.org/jira/browse/LENS-1158
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> One of the log looks the following:
> 
> 27 May 2016 04:10:24 [bf1c4dce-f578-4237-8035-b3ba6846319e] [cbfb48cc-e1eb-4b58-9db4-b5b09d15a55d 36caf230-8e8a-4b4d-a0ef-857ec94c0996 7e180c99-0d54-42a0-86e7-d9f88e7e5942 f302b519-9397-4b82-8f50-c1fc93da58d8 097a39a7-b948-4804-ad77-f6beab75a017 1461e1a1-cb77-4c7a-8b20-85969dbcbc9e 656edc21-6050-4174-aa2b-d6ea9d1f71de 276d7420-c9c3-43b2-94f1-e26282b9d24c grizzly-http-server-32] ERROR hive.ql.metadata.Table - Unable to get field from serde:....
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5 
> 
> Diff: https://reviews.apache.org/r/48007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 48007: LENS-1158: Thread names with hive2 build are growing huge

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48007/#review135621
-----------------------------------------------------------


Ship it!




Ship It!

- Puneet Gupta


On May 28, 2016, 10:43 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48007/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 10:43 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1158
>     https://issues.apache.org/jira/browse/LENS-1158
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> One of the log looks the following:
> 
> 27 May 2016 04:10:24 [bf1c4dce-f578-4237-8035-b3ba6846319e] [cbfb48cc-e1eb-4b58-9db4-b5b09d15a55d 36caf230-8e8a-4b4d-a0ef-857ec94c0996 7e180c99-0d54-42a0-86e7-d9f88e7e5942 f302b519-9397-4b82-8f50-c1fc93da58d8 097a39a7-b948-4804-ad77-f6beab75a017 1461e1a1-cb77-4c7a-8b20-85969dbcbc9e 656edc21-6050-4174-aa2b-d6ea9d1f71de 276d7420-c9c3-43b2-94f1-e26282b9d24c grizzly-http-server-32] ERROR hive.ql.metadata.Table - Unable to get field from serde:....
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5 
> 
> Diff: https://reviews.apache.org/r/48007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 48007: LENS-1158: Thread names with hive2 build are growing huge

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On May 30, 2016, 5:25 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 82
> > <https://reviews.apache.org/r/48007/diff/1/?file=1400398#file1400398line82>
> >
> >     Why do we need these changes along with IVE-13885?  Looks like these changes are redundant.

No. The acquire-release are happening in http worker threads. So each thread should have its own stack of acquire-release.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48007/#review135457
-----------------------------------------------------------


On May 28, 2016, 4:13 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48007/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 4:13 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1158
>     https://issues.apache.org/jira/browse/LENS-1158
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> One of the log looks the following:
> 
> 27 May 2016 04:10:24 [bf1c4dce-f578-4237-8035-b3ba6846319e] [cbfb48cc-e1eb-4b58-9db4-b5b09d15a55d 36caf230-8e8a-4b4d-a0ef-857ec94c0996 7e180c99-0d54-42a0-86e7-d9f88e7e5942 f302b519-9397-4b82-8f50-c1fc93da58d8 097a39a7-b948-4804-ad77-f6beab75a017 1461e1a1-cb77-4c7a-8b20-85969dbcbc9e 656edc21-6050-4174-aa2b-d6ea9d1f71de 276d7420-c9c3-43b2-94f1-e26282b9d24c grizzly-http-server-32] ERROR hive.ql.metadata.Table - Unable to get field from serde:....
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5 
> 
> Diff: https://reviews.apache.org/r/48007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 48007: LENS-1158: Thread names with hive2 build are growing huge

Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48007/#review135457
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 82)
<https://reviews.apache.org/r/48007/#comment200469>

    Why do we need these changes along with IVE-13885?  Looks like these changes are redundant.


- Raju Bairishetti


On May 28, 2016, 10:43 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48007/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 10:43 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1158
>     https://issues.apache.org/jira/browse/LENS-1158
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> One of the log looks the following:
> 
> 27 May 2016 04:10:24 [bf1c4dce-f578-4237-8035-b3ba6846319e] [cbfb48cc-e1eb-4b58-9db4-b5b09d15a55d 36caf230-8e8a-4b4d-a0ef-857ec94c0996 7e180c99-0d54-42a0-86e7-d9f88e7e5942 f302b519-9397-4b82-8f50-c1fc93da58d8 097a39a7-b948-4804-ad77-f6beab75a017 1461e1a1-cb77-4c7a-8b20-85969dbcbc9e 656edc21-6050-4174-aa2b-d6ea9d1f71de 276d7420-c9c3-43b2-94f1-e26282b9d24c grizzly-http-server-32] ERROR hive.ql.metadata.Table - Unable to get field from serde:....
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5 
> 
> Diff: https://reviews.apache.org/r/48007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>