You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/31 13:39:29 UTC

[GitHub] [incubator-mxnet] justanotheruser opened a new pull request #20108: [TEST] Added cpp package to CI build for windows

justanotheruser opened a new pull request #20108:
URL: https://github.com/apache/incubator-mxnet/pull/20108


   ## Description ##
   Added cpp package creation to CI build for windows
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   Changes ARE test coverage
   
   ## Comments ##
   - Mostly created to run CI and check that problem is on my side ( https://github.com/apache/incubator-mxnet/issues/20099 )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on pull request #20108: [TEST] Added cpp package to CI build for windows

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20108:
URL: https://github.com/apache/incubator-mxnet/pull/20108#issuecomment-813568328


   ```
   [2021-03-31T15:35:33.219Z]   File "OpWrapperGenerator.py", line 433, in <module>
   
   [2021-03-31T15:35:33.219Z]     raise(e)
   
   [2021-03-31T15:35:33.219Z]   File "OpWrapperGenerator.py", line 427, in <module>
   
   [2021-03-31T15:35:33.219Z]     f.write(patternStr % ParseAllOps())
   
   [2021-03-31T15:35:33.219Z]   File "OpWrapperGenerator.py", line 321, in ParseAllOps
   
   [2021-03-31T15:35:33.219Z]     cdll.libmxnet = cdll.LoadLibrary(sys.argv[1])
   
   ```
   
   Probably need to specify "The winmode parameter is used on Windows to specify how the library is loaded (since mode is ignored). It takes any value that is valid for the Win32 API LoadLibraryEx flags parameter. When omitted, the default is to use the flags that result in the most secure DLL load to avoiding issues such as DLL hijacking. Passing the full path to the DLL is the safest way to ensure the correct library and dependencies are loaded." as in the libinfo.py file of the Python API https://docs.python.org/3/library/ctypes.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20108: [TEST] Added cpp package to CI build for windows

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20108:
URL: https://github.com/apache/incubator-mxnet/pull/20108#issuecomment-811076163


   Hey @justanotheruser , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-cpu, miscellaneous, unix-gpu, website, sanity, centos-gpu, windows-gpu, windows-cpu, clang, edge, centos-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org