You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/06 16:04:45 UTC
[GitHub] [incubator-tvm] tqchen opened a new issue #5250: [REFACTOR]
StringImm -> String
tqchen opened a new issue #5250: [REFACTOR] StringImm -> String
URL: https://github.com/apache/incubator-tvm/issues/5250
We have introduced the runtime::String to the tvm runtime. This new object can be used to replace most of the StringImm usages, except for the one that uses the IR. This issue tracks the refactor items to perform such migration
- [ ] Expose runtime::String to the tvm namespace https://github.com/apache/incubator-tvm/blob/master/include/tvm/node/node.h#L59
- [ ] Change ffi_node_api String to return runtime::String instead of StringImm https://github.com/apache/incubator-tvm/blob/master/python/tvm/runtime/object_generic.py#L59
- [ ] Remove the constructor from const char* for PrimExpr, this will reveal a lot of failures in compiler checks for the cases where we need to use String instead.
- [ ] At this point, we will need quite a lot of failures in the topi side, fix most of the occurence of StringImm(usually under type PrimExpr and Array<PrimExpr>)
- [ ] Keep the compiler ir part to still use StringImm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5250: [REFACTOR]
StringImm -> String
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5250: [REFACTOR] StringImm -> String
URL: https://github.com/apache/incubator-tvm/issues/5250#issuecomment-610567541
@tqchen I will spend some time on this. I just had simple test based on #5251. It looks I had a problem. Could you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics edited a comment on issue #5250: [REFACTOR]
StringImm -> String
Posted by GitBox <gi...@apache.org>.
zhiics edited a comment on issue #5250: [REFACTOR] StringImm -> String
URL: https://github.com/apache/incubator-tvm/issues/5250#issuecomment-610567541
@tqchen I will spend some time on this. I just had simple test based on #5251. It looks I had a problem. Could you please take a look at the comment there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5250: [REFACTOR]
StringImm -> String
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5250: [REFACTOR] StringImm -> String
URL: https://github.com/apache/incubator-tvm/issues/5250#issuecomment-609886066
cc @wweic @zhiics please see if you can take the rest of the items in the incoming week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5250: [REFACTOR]
StringImm -> String
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5250: [REFACTOR] StringImm -> String
URL: https://github.com/apache/incubator-tvm/issues/5250#issuecomment-612147673
closed by #5276 Thanks to @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5250: [REFACTOR]
StringImm -> String
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5250: [REFACTOR] StringImm -> String
URL: https://github.com/apache/incubator-tvm/issues/5250#issuecomment-609886066
cc @wweic @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen closed issue #5250: [REFACTOR] StringImm ->
String
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #5250: [REFACTOR] StringImm -> String
URL: https://github.com/apache/incubator-tvm/issues/5250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services