You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by rectang <gi...@git.apache.org> on 2016/04/13 06:46:52 UTC

[lucy-dev] [GitHub] lucy pull request: LUCY-295 BitVector size_t ticks

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy/pull/40

    LUCY-295 BitVector size_t ticks

    Change BitVector to use `size_t` instead of `uint32_t` to address bits in the array.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy LUCY-295-bitvec-size

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 07285699c4f819d9be0dc1c7984c2bfe79be7851
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-06T23:30:49Z

    Change BitVector to use size_t indexes.
    
    Have BitVector use a size_t to track its capacity and to index into the
    bit array.

commit efd6ac7bf73ffa4b99bfe493bb3ef1ef5c5e8ef6
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-07T00:41:12Z

    Factor out routine for octet size calculation.
    
    Create a dedicated static function which given a bit size returns a byte
    size.

commit 0a6ea88df1e5064609561e874b74707c855097b2
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-07T00:51:01Z

    Widen arguments to BitVector functions.
    
    BitVector API functions now take size_t indexes rather than uint32_t.

commit e03b8c7160bca49bb212bdf027a7f9ca2d2c4524
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-07T00:56:36Z

    Rework BitVector tests for index width change.
    
    Changing indexes from uint32_t to size_t requires updating a fair amount
    of test code.

commit 71d7edd2c2c1eeaf1a1b4e8b9a01a621b53180d4
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-07T01:00:30Z

    Adapt for changed BitVector return value APIs.
    
    BitVec counts and sizes are now measured in size_t not uint32_t.

commit 42640a6f408adb78556532b6a43f4d71cd842caa
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-07T01:16:57Z

    Adapt Go bindings for BitVector width change.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[lucy-dev] [GitHub] lucy pull request: LUCY-295 BitVector size_t ticks

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucy/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---