You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/10/08 07:44:11 UTC
(texera) 01/01: refactor(frontend): remove the unused loadFile output (#8892)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8892-a42c573f7d4515fbaa4dcecbb4399b01829310ef
in repository https://gitbox.apache.org/repos/asf/texera.git
commit be65bf8564a32eea4196aa0190a04f73884bfe70
Author: Xinyuan Lin <xi...@uci.edu>
AuthorDate: Thu Oct 8 07:40:40 2026 +0000
refactor(frontend): remove the unused loadFile output (#8892)
### What changes were proposed in this PR?
Removes the unused `@Output() loadFile` from
`UserDatasetFileRendererComponent`, along with `EventEmitter` and
`Output` from its `@angular/core` import, since nothing else in the file
uses them. **+1/−4 lines.** There is no behaviour change: the component
never emits `loadFile`, and its two hosts (`dataset-detail` and
`model-detail`) bind only inputs on
`<texera-user-dataset-file-renderer>`.
### History
| | |
| --- | --- |
| **Introduced by** | #2413 (2024-02-26), "Introduce Dataset GUI", with
the file renderer itself |
| **Usage removed by** | **never used**. No `(loadFile)` binding or
`.emit` has ever existed |
It has been unused for the nineteen months since it was added.
### Any related issues, documentation, discussions?
Closes #8891
### How was this PR tested?
No new tests; no spec referenced the output.
From `frontend/`:
- `npx ng test --watch=false
--include='**/user-dataset-file-renderer.component.spec.ts'
--include='**/dataset-detail.component.spec.ts'
--include='**/model-detail.component.spec.ts'`: 3 files, 286 tests, all
pass. The last two specs cover the renderer's two hosts.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -n -w "loadFile" -- frontend/src # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
.../user-dataset-file-renderer.component.ts | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts
index d6150ee633..85180685a8 100644
--- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts
+++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts
@@ -17,7 +17,7 @@
* under the License.
*/
-import { Component, EventEmitter, Input, OnChanges, OnDestroy, OnInit, Output, SimpleChanges } from "@angular/core";
+import { Component, Input, OnChanges, OnDestroy, OnInit, SimpleChanges } from "@angular/core";
import { ResourceRegistryService } from "../../../../../service/user/resource-registry/resource-registry.service";
import { EntityType } from "../../../../../../hub/service/hub.service";
import { UntilDestroy, untilDestroyed } from "@ngneat/until-destroy";
@@ -166,9 +166,6 @@ export class UserDatasetFileRendererComponent implements OnInit, OnChanges, OnDe
@Input()
isLogin: boolean = false;
- @Output()
- loadFile = new EventEmitter<{ file: string; prefix: string }>();
-
constructor(
private resourceRegistry: ResourceRegistryService,
private sanitizer: DomSanitizer,