You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/14 21:31:05 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28809: [SPARK-31959][SQL][3.0] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

dongjoon-hyun commented on a change in pull request #28809:
URL: https://github.com/apache/spark/pull/28809#discussion_r439869464



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/RebaseDateTimeSuite.scala
##########
@@ -409,4 +409,40 @@ class RebaseDateTimeSuite extends SparkFunSuite with Matchers with SQLHelper {
       }
     }
   }
+
+  test("SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945") {

Review comment:
       Please hold on this. This test case is flaky in `master` branch already.
   - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-3.2-hive-2.3/lastCompletedBuild/testReport/org.apache.spark.sql.catalyst.util/RebaseDateTimeSuite/SPARK_31959__JST____HKT_at_Asia_Hong_Kong_in_1945/
   ```
   - SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945 *** FAILED ***
     -766744200000000 did not equal -766747800000000 (RebaseDateTimeSuite.scala:432)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org