You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/06 14:20:02 UTC
[GitHub] [shardingsphere] everly-gif opened a new pull request, #16618: Support Parsing `DROP RULE` in PostgreSQL
everly-gif opened a new pull request, #16618:
URL: https://github.com/apache/shardingsphere/pull/16618
Related to issue #.
Changes proposed in this pull request:
- Adds `DROP RULE`
- Adds `Tests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #16618: Support Parsing `DROP RULE` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on PR #16618:
URL: https://github.com/apache/shardingsphere/pull/16618#issuecomment-1090832285
> I get an error : `1 counts of IllegalAnnotationExceptions Two classes have the same XML type name "dropRuleStatementTestCase"`
>
> ```
> this problem is related to the following location:
> at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.ddl.DropRuleStatementTestCase
> at private final java.util.List org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases.dropRuleTestCases
> at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases
> this problem is related to the following location:
> at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.DropRuleStatementTestCase
> at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.rdl.drop.DropReadwriteSplittingRuleStatementTestCase
> at private final java.util.List org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases.dropReadwriteSplittingRuleTestCase
> at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases
> ```
>
> That's the one failing CI
as the error text indicate, there are two classes named `dropRuleStatementTestCase`, another one is [here](https://github.com/lanchengx/shardingsphere/blob/b43c530a1a91fde26e66c623b69fee24bc12bc2e/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/DropRuleStatementTestCase.java) for `distsql drop rule`, maybe you can try to annotate that class with `@XmlType(name="distsql")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #16618: Support Parsing `DROP RULE` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on PR #16618:
URL: https://github.com/apache/shardingsphere/pull/16618#issuecomment-1091102364
Hi @everly-gif, can you solve code conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #16618: Support Parsing `DROP RULE` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #16618:
URL: https://github.com/apache/shardingsphere/pull/16618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] everly-gif commented on pull request #16618: Support Parsing `DROP RULE` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
everly-gif commented on PR #16618:
URL: https://github.com/apache/shardingsphere/pull/16618#issuecomment-1090984841
Thanks @Liangda-w , I wanted to know if there was some other way to go about it, thanks for always guiding me. I have made the changes , please do review them! Also the tag for this PR should be `db: PostgreSQL` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16618: Support Parsing `DROP RULE` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16618:
URL: https://github.com/apache/shardingsphere/pull/16618#issuecomment-1091051420
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16618](https://codecov.io/gh/apache/shardingsphere/pull/16618?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02d3b24) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f5d3a742090d6490da789980f53b7db1275b1844?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5d3a74) will **increase** coverage by `0.00%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## master #16618 +/- ##
=========================================
Coverage 60.74% 60.74%
- Complexity 2094 2095 +1
=========================================
Files 3349 3352 +3
Lines 50690 50697 +7
Branches 8713 8713
=========================================
+ Hits 30793 30798 +5
- Misses 17307 17309 +2
Partials 2590 2590
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16618?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/sql/common/statement/ddl/DropRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kZGwvRHJvcFJ1bGVTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...nt/postgresql/ddl/PostgreSQLDropRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kZGwvUG9zdGdyZVNRTERyb3BSdWxlU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...es/domain/statement/DropRuleStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/16618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L0Ryb3BSdWxlU3RhdGVtZW50VGVzdENhc2UuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...atement/impl/PostgreSQLDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/16618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9Qb3N0Z3JlU1FMRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `81.93% <100.00%> (+0.07%)` | :arrow_up: |
| [...l/parser/core/database/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/16618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2RhdGFiYXNlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...eterized/jaxb/cases/domain/SQLParserTestCases.java](https://codecov.io/gh/apache/shardingsphere/pull/16618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vU1FMUGFyc2VyVGVzdENhc2VzLmphdmE=) | `99.83% <100.00%> (+<0.01%)` | :arrow_up: |
| [...omain/statement/ddl/DropRuleStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/16618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2RkbC9Ecm9wUnVsZVN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16618?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16618?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f5d3a74...02d3b24](https://codecov.io/gh/apache/shardingsphere/pull/16618?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] everly-gif commented on pull request #16618: Support Parsing `DROP RULE` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
everly-gif commented on PR #16618:
URL: https://github.com/apache/shardingsphere/pull/16618#issuecomment-1090403656
I get an error : `1 counts of IllegalAnnotationExceptions
Two classes have the same XML type name "dropRuleStatementTestCase"`
```
this problem is related to the following location:
at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.ddl.DropRuleStatementTestCase
at private final java.util.List org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases.dropRuleTestCases
at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases
this problem is related to the following location:
at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.DropRuleStatementTestCase
at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.statement.distsql.rdl.drop.DropReadwriteSplittingRuleStatementTestCase
at private final java.util.List org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases.dropReadwriteSplittingRuleTestCase
at org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.SQLParserTestCases
```
That's the one failing CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] everly-gif commented on pull request #16618: Support Parsing `DROP RULE` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
everly-gif commented on PR #16618:
URL: https://github.com/apache/shardingsphere/pull/16618#issuecomment-1091133334
Sure, fixed it @strongduanmu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org