You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2024/05/01 01:08:27 UTC

Re: [PR] Use more efficient variants of URLEncoder::encode and URLDecoder::decode [pinot]

yashmayya commented on code in PR #13030:
URL: https://github.com/apache/pinot/pull/13030#discussion_r1585766357


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -574,7 +569,7 @@ public String forUpdateTagsValidation() {
 
   private static String encode(String s) {
     try {
-      return URLEncoder.encode(s, "UTF-8");
+      return URLEncoder.encode(s, StandardCharsets.UTF_8);

Review Comment:
   Whoops, missed this one. Done, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org