You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/10/05 00:08:47 UTC

Review Request 62780: Mesos UI: used relative paths for master endpoints and static resources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62780/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Use relative paths for static resources (js scripts, css stylesheets,
images, etc.) and for URLs corresponding to master endpoints.

This change makes these links/urls accessible via a reverse proxy.


Diffs
-----

  src/webui/master/static/index.html d657eb3b6eab5f4c94bdf89a131244ac28972653 
  src/webui/master/static/js/controllers.js d4904f88abf21309b76e1075d89d254a7f11ae82 
  src/webui/master/static/pailer.html 759b18023ee7a23d448329c16028bb2a087a09d8 


Diff: https://reviews.apache.org/r/62780/diff/1/


Testing
-------

Verified that the UI still works when running a master and agent on a remote server.

I tried:

  * Clicking all the tabs.
  * Viewing the master/agent logs.
  * Browsing a task sandbox and reading a file using the pailer.


Thanks,

Gaston Kleiman