You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/02/23 08:34:17 UTC
[GitHub] zeppelin pull request #2058: [ZEPPELIN-2147] zeppelin should redirect to log...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2058
[ZEPPELIN-2147] zeppelin should redirect to login page after browser session expires
### What is this PR for?
Zeppelin should redirect to login page after browser session expires
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [https://issues.apache.org/jira/browse/ZEPPELIN-2147](https://issues.apache.org/jira/browse/ZEPPELIN-2147)
### How should this be tested?
- Open any Zeppelin's notebook on a browser
- Restart zeppelin server
- now as soon as next web-socket message or API request is sent to server that returns either "ticket is invalid" or 405. This should get redirected to login page.
- On successful login it should take user back to the page from where he was coming from.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2147
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2058.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2058
----
commit 6486383c0816f033feb0803b3de98f94db6739ab
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-23T08:13:18Z
in case of session lost or logout, show login window
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2058
https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204880085 (229.2) failed but https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204547180 passed.
Merging this to master and branch-0.7 if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2058: [ZEPPELIN-2147] zeppelin should redirect to log...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2058
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2058
Thank you @r-kamath for reviewing this. Have handled your review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2058: [ZEPPELIN-2147] zeppelin should redirect to log...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2058
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2058: [ZEPPELIN-2147] zeppelin should redirect to log...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2058
[ZEPPELIN-2147] zeppelin should redirect to login page after browser session expires
### What is this PR for?
Zeppelin should redirect to login page after browser session expires
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [https://issues.apache.org/jira/browse/ZEPPELIN-2147](https://issues.apache.org/jira/browse/ZEPPELIN-2147)
### How should this be tested?
- Open any Zeppelin's notebook on a browser
- Restart zeppelin server
- now as soon as next web-socket message or API request is sent to server that returns either "ticket is invalid" or 405. This should get redirected to login page.
- On successful login it should take user back to the page from where he was coming from.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2147
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2058.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2058
----
commit 918908903125a7a4d3fef645174153cf62530c29
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-23T08:13:18Z
in case of session lost or logout, show login window
commit 27bc361415c792f8666a9a67a423150d5887f0e6
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-24T07:31:10Z
user $timeout with $location
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2058
Thank you @khalidhuseynov for taking a look at this. CI is green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2058
On retrying CI is green now. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204880085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2058
On retrying the same build, CI is green. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204880085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2058
changes look good, may need to check the CI though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---