You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/24 14:49:46 UTC
[GitHub] [cloudstack-kubernetes-provider] onitake opened a new pull request #17: Remove vendored dependencies
onitake opened a new pull request #17:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17
As discussed in #8 , these are no longer necessary thanks to the first-class module support in Go 1.13+.
Matching dependency versions is ensured through go.mod and go.sum.
Build and test results:
```
$ make
go build -ldflags "-X k8s.io/kubernetes/pkg/version.gitVersion=0.0.0-master+929042981f203abf8a01ea4271892e4484ca2d7d -X k8s.io/kubernetes/pkg/version.gitCommit=929042981f203abf8a01ea4271892e4484ca2d7d -X k8s.io/kubernetes/pkg/version.buildDate=2020-09-24T14:43:05Z" -o cloudstack-ccm cmd/cloudstack-ccm/main.go
$ ls -sh cloudstack-ccm
53M cloudstack-ccm
$ go vet && echo Pass
Pass
$ go test -v
=== RUN TestReadConfig
--- PASS: TestReadConfig (0.00s)
=== RUN TestNewCSCloud
cloudstack_test.go:89: No config found in environment
--- SKIP: TestNewCSCloud (0.00s)
=== RUN TestLoadBalancer
cloudstack_test.go:101: No config found in environment
--- SKIP: TestLoadBalancer (0.00s)
PASS
ok github.com/apache/cloudstack-kubernetes-provider 0.005s
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #17: Remove vendored dependencies
Posted by GitBox <gi...@apache.org>.
onitake commented on pull request #17:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17#issuecomment-708404459
Thanks for the go-ahead @davidjumani , but I don't have permission to merge.
@rhtyd Can you merge, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #17: Remove vendored dependencies
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #17:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #17: Remove vendored dependencies
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #17:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17#issuecomment-708190591
@onitake Go ahead and merge this so that I can rebase and submit #22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org