You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/25 11:41:29 UTC
[GitHub] [beam] sonam-vend opened a new pull request #12938: Integrated Nebula plugin
sonam-vend opened a new pull request #12938:
URL: https://github.com/apache/beam/pull/12938
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (766e0eb) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
- Hits 47584 47583 -1
- Misses 9930 9935 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...b47662e](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) (3d6cc0e) will **increase** coverage by `0.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.73% +0.24%
==========================================
Files 455 466 +11
Lines 54876 57518 +2642
==========================================
+ Hits 45266 47585 +2319
- Misses 9610 9933 +323
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/examples/snippets/snippets.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvc25pcHBldHMucHk=) | `76.97% <0.00%> (-12.55%)` | :arrow_down: |
| [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `74.30% <0.00%> (-5.24%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.63% <0.00%> (-4.55%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <0.00%> (-4.14%)` | :arrow_down: |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `74.55% <0.00%> (-2.99%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `92.03% <0.00%> (-1.94%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.90% <0.00%> (-1.82%)` | :arrow_down: |
| [...thon/apache\_beam/io/aws/clients/s3/boto3\_client.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvczMvYm90bzNfY2xpZW50LnB5) | `13.33% <0.00%> (-1.52%)` | :arrow_down: |
| ... and [113 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [405204c...e794e82](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r535252301
##########
File path: runners/flink/1.11/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.11.1"
+def flink_annotations_version = "1.11.1"
+def flink_optimizer_version = "1.11.1"
Review comment:
Done as per your recommendation :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/utils/sharded\_key.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmRlZF9rZXkucHk=) | | |
| [...he\_beam/transforms/combinefn\_lifecycle\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lZm5fbGlmZWN5Y2xlX3BpcGVsaW5lLnB5) | | |
| [...ks/python/apache\_beam/internal/metrics/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9fX2luaXRfXy5weQ==) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...3af3802](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (be64412) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47581 -3
- Misses 9930 9933 +3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...be64412](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (aa22d1b) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47587 +3
- Misses 9930 9931 +1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.31% <0.00%> (-0.52%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.57% <0.00%> (+0.24%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `89.63% <0.00%> (+1.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...aa22d1b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550126643
##########
File path: sdks/java/container/license_scripts/dep_urls_java.yaml
##########
@@ -48,5 +48,5 @@ paranamer:
'2.7':
license: "https://raw.githubusercontent.com/paul-hammant/paranamer/master/LICENSE.txt"
xz:
- '1.8':
- license: "https://git.tukaani.org/?p=xz-java.git;a=blob_plain;f=COPYING;h=c1d404dc7a6f06a0437bf1055fedaa4a4c89d728;hb=HEAD"
+ '1.5':
+ license: "https://git.tukaani.org/?p=xz-java.git;a=blob;f=COPYING;h=c1d404dc7a6f06a0437bf1055fedaa4a4c89d728;hb=9f1f97a26f090ffec6568c004a38c6534aa82b94"
Review comment:
For sdks:java:container:pullLicenses task to succeed, i had to downgrade xz licence version from 1.8 to 1.5 as suggested by the build scan https://scans.gradle.com/s/2tv254pmdrzxq/console-log?task=:sdks:java:container:pullLicenses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) (3d6cc0e) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [8b4b78e...c65966e](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...les/complete/juliaset/juliaset/juliaset\_test\_it.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvanVsaWFzZXRfdGVzdF9pdC5weQ==) | | |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | | |
| [sdks/python/apache\_beam/utils/sharded\_key.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmRlZF9rZXkucHk=) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...10cfaef](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (ab8fb61) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47582 -2
- Misses 9930 9932 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...ab8fb61](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left and doing some sort/uniq/diff on bash) this is the only task that actually gets called twice . Not sure if that's expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test, :runners:flink:1.11:test, :runners:samza:compileTestJava
Could this failure be related to the same test being called more than once in the same runtime instance. Is it worth looking into removing this duplicate calling of tasks? Or maybe there's a simpler answer....
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7223fb3...4bbe3e5](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7223fb3...000eb99](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752301262
@kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though its excluded from beam/runners/portability/java/build.gradle
(excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-753546217
> @ibzib , I consider it is quite large and critical change to be merged all at once. Responding to your suggestion of splitting this PR into multiple separate PR, I am thinking to split this PR into 8 sub PRs as:
>
> 1. Module A | beam/example/java
> 2. Module B | beam/model
> 3. Module C | beam/runners/core-construction-java, runners/core-java, runners/direct-java, runners/extensions-java
> 4. Module D | runners/flink, runners/google-cloud-dataflow-java,runners/google-cloud-dataflow-java, runners/java-fn-execution, runners/java-job-service, runners/jet
> 5. Module E | runners/local-java, runners/portability, runners/samza, runners/spark, runners/twister2
> 6. Module F | sdks/java/bom, sdks/java/build-tools, sdks/java/container, sdks/java/core
> 7. Module G | sdks/java/expansion-service, sdks/java/extensions, sdks/java/fn-execution, sdks/java/harness
> 8. Module H | sdks/java/io, sdks/java/javadoc, sdks/java/maven-archetypes, sdks/java/testing
It's up to your discretion, but in general, I would break it into the smallest PRs possible. In other words, wherever you can change one subproject independently of all the others, do so. Specifically, each runner (`runners/flink`, `runners/spark`, etc.) should probably get its own PR to be reviewed by one of the maintainers of that runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b1cb732) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.80%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.60% +47.80%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47499 +28355
+ Misses 35864 10004 -25860
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <ø> (+42.67%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...808cc6b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.58% -0.15%
==========================================
Files 466 466
Lines 57514 57503 -11
==========================================
- Hits 47584 47491 -93
- Misses 9930 10012 +82
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (-14.57%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/userstate.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91c2Vyc3RhdGUucHk=) | `82.18% <0.00%> (-2.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/core.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb3JlLnB5) | `88.92% <0.00%> (-2.59%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `88.88% <0.00%> (-1.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <0.00%> (-1.29%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `84.17% <0.00%> (-0.98%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/ptransform.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5) | `92.02% <0.00%> (-0.94%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.49% <0.00%> (-0.84%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...658f482](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-749689821
Run Python_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847421
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,19 +32,26 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
-
+ compile library.java.joda_time
Review comment:
nitpick - there should be a blank line between "compile" and "testcompile" lines like before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ython/apache\_beam/portability/api/endpoints\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...che\_beam/portability/api/beam\_provision\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcHJvdmlzaW9uX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/beam\_job\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...beam/portability/api/beam\_artifact\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMl9ncnBjLnB5) | `56.98% <0.00%> (ø)` | |
| [...beam/portability/api/beam\_artifact\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMl91cm5zLnB5) | `0.00% <0.00%> (ø)` | |
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMl9ncnBjLnB5) | `72.64% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-751788539
Run Go PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (8b45b0f) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47587 +3
+ Misses 9934 9931 -3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.57% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.28% <0.00%> (+0.35%)` | :arrow_up: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...8b45b0f](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/portability/api/beam\_artifact\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMl91cm5zLnB5) | `0.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/external\_transforms\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_job\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjJfZ3JwYy5weQ==) | `56.98% <0.00%> (ø)` | |
| [...m/portability/api/beam\_interactive\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMl9ncnBjLnB5) | `0.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/metrics\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/standard\_window\_fns\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/portability/api/schema\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3NjaGVtYV9wYjJfZ3JwYy5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...5ed53e5](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47585 +1
+ Misses 9934 9933 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.83% <0.00%> (+0.12%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-746080441
Run Java PreCommit"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530513655
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -43,40 +43,13 @@ class GrpcVendoring_1_26_0 {
static def npn_api_version = "1.1.1.v20141010"
static def jboss_marshalling_version = "1.4.11.Final"
static def jboss_modules_version = "1.1.0.Beta1"
-
/** Returns the list of compile time dependencies. */
static List<String> dependencies() {
return [
- "com.google.guava:guava:$guava_version",
Review comment:
@kennknowles ./gradlew analyzeDependencies is successfull. Apparently, there are no linkage errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752701353
@shehzaadn-vd Some explanation for the behavior you saw:
> any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
`testTeardownCalledAfterExceptionInProcessElement` is a `ValidatesRunner` test. `ValidatesRunner` tests are meant to be run by different runners. Each runner defines its own list for which `ValidatesRunner` tests to skip (typically because they are not expected to pass).
> Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left of the screen and doing some sort/uniq/diff on bash) this is being executed multiple times.
No task is being executed multiple times. The "Executed Gradle Tasks" list is somewhat misleading in this regard. It prints out the task name every time it sees a log line starting with `> Task`. Because the logs are ordered chronologically, and Jenkins can execute many tasks in parallel, logs for different tasks become interleaved. Gradle prints `> Task X` each time so you can tell the logs apart. So when `> Task A` appears twice, it's not because it is running again, it's because some other task B printed logs in between task A's.
> It looks like running Run Java PreCommit again fixed the issue - which suggests the test is a bit unstable, but unrelated to this PR.
I agree. When you encounter what you suspect to be a flaky test, you can look on JIRA to see if anyone else has run into it. If no one's filed an issue yet, please create one. (I created BEAM-11541 for `testTeardownCalledAfterExceptionInProcessElement`.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/internal/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9jZWxscy5weQ==) | | |
| [...les/complete/juliaset/juliaset/juliaset\_test\_it.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvanVsaWFzZXRfdGVzdF9pdC5weQ==) | | |
| [sdks/python/apache\_beam/utils/sentinel.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2VudGluZWwucHk=) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...7868898](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47585 +1
+ Misses 9934 9933 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.83% <0.00%> (+0.12%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847509
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -50,50 +50,55 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-grpclb'
}
compile library.java.google_cloud_core
- compile(library.java.google_cloud_core_grpc) {
- exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
- }
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
- compile library.java.grpc_alts
compile library.java.grpc_auth
- compile library.java.grpc_core
- compile library.java.grpc_context
- compile library.java.grpc_grpclb
+ testImplementation 'io.grpc:grpc-core:1.27.2'
compile library.java.grpc_netty
- compile library.java.grpc_netty_shaded
- compile library.java.grpc_stub
compile library.java.grpc_google_cloud_pubsub_v1
- compile library.java.grpc_google_cloud_pubsublite_v1
+ //compile library.java.grpc_google_cloud_pubsublite_v1
Review comment:
this line should be removed - not commented out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7c357e4...343c171](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [4619286...fd61007](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (9a773af) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47595 +11
+ Misses 9930 9923 -7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.11% <0.00%> (+2.20%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...20703a1](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) (3d6cc0e) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [8b4b78e...342a315](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r541008797
##########
File path: runners/google-cloud-dataflow-java/worker/windmill/build.gradle
##########
@@ -36,3 +36,9 @@ configurations {
artifacts {
unshaded jar
}
+
+dependencies {
+ compile "com.google.guava:guava:28.1-android"
Review comment:
I declared com.google.guava:guava:28.1-android in BeamModulePlugin.java like this,
guava_android : "com.google.guava:guava:28.1-android",
then I tried to use it in the build.gradle files like,1
compile library.java.guava_android
But I have been getting,
` Task :sdks:java:build-tools:compileJava
An exception has occurred in the compiler ((version info not available)). Please file a bug against the Java compiler via the Java bug reporting page (http://bugreport.java.com) after checking the Bug Database (http://bugs.java.com) for duplicates. Include your program and the following diagnostic in your report. Thank you.
java.lang.NoSuchMethodError: com.google.common.collect.ImmutableSet.toImmutableSet()Ljava/util/stream/Collector;
at com.google.errorprone.BugCheckerInfo.<init>(BugCheckerInfo.java:118)
at com.google.errorprone.BugCheckerInfo.create(BugCheckerInfo.java:104)
at com.google.errorprone.scanner.BuiltInCheckerSuppliers.getSuppliers(BuiltInCheckerSuppliers.java:318)
at com.google.errorprone.scanner.BuiltInCheckerSuppliers.getSuppliers(BuiltInCheckerSuppliers.java:311)
at com.google.errorprone.scanner.BuiltInCheckerSuppliers.<clinit>(BuiltInCheckerSuppliers.java:347)
at com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:44)
at com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:214)
at com.sun.tools.javac.api.JavacTaskImpl.prepareCompiler(JavacTaskImpl.java:192)
at com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:97)
at com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:142)
at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:96)
at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:90)
at org.gradle.internal.compiler.java.IncrementalCompileTask.call(IncrementalCompileTask.java:74)
at org.gradle.api.internal.tasks.compile.AnnotationProcessingCompileTask.call(AnnotationProcessingCompileTask.java:94)
at org.gradle.api.internal.tasks.compile.ResourceCleaningCompilationTask.call(ResourceCleaningCompilationTask.java:57)
at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:55)
at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:40)
at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerWorkAction.execute(AbstractDaemonCompiler.java:135)
at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:49)
at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:43)
at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:97)
at org.gradle.workers.internal.AbstractClassLoaderWorker.executeInClassLoader(AbstractClassLoaderWorker.java:43)
at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:32)
at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:22)
at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:85)
at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:55)
at org.gradle.process.internal.worker.request.WorkerAction$1.call(WorkerAction.java:138)
at org.gradle.process.internal.worker.child.WorkerLogEventListener.withWorkerLoggingProtocol(WorkerLogEventListener.java:41)
at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:135)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
at java.lang.Thread.run(Thread.java:748)
> Task :sdks:java:build-tools:compileJava FAILED
`
If I use "com.google.guava:guava:28.1-android" as it is, build is a success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r549472774
##########
File path: sdks/go/gogradle.lock
##########
@@ -1,716 +0,0 @@
-# This file is generated by gogradle automatically, you should NEVER modify it manually.
Review comment:
Undelete this file, it's what locks the go deps for jenkins right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...0552aeb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib closed pull request #12938: [BEAM-10961] Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
ibzib closed pull request #12938:
URL: https://github.com/apache/beam/pull/12938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...61cb207](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left and doing some sort/uniq/diff on bash) this is the only task that actually gets called twice . Not sure if that's expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test, :runners:flink:1.11:test, :runners:samza:compileTestJava
Could this failure be related to the same test being called more than once in the same runtime instance. Is it worth looking into removing this duplicate calling of tasks? Or maybe there's a simpler answer....
@kennknowles @ibzib
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (9a773af) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47595 +11
+ Misses 9930 9923 -7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.11% <0.00%> (+2.20%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...9a773af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/transforms/combinefn\_lifecycle\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lZm5fbGlmZWN5Y2xlX3BpcGVsaW5lLnB5) | | |
| [...pache\_beam/dataframe/pandas\_top\_level\_functions.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3BhbmRhc190b3BfbGV2ZWxfZnVuY3Rpb25zLnB5) | | |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [31716b0...3b00f47](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...a0ff883](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (aa22d1b) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47587 +3
- Misses 9930 9931 +1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.31% <0.00%> (-0.52%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.57% <0.00%> (+0.24%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `89.63% <0.00%> (+1.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...aa22d1b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/standard\_window\_fns\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [.../apache\_beam/portability/api/endpoints\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjJfZ3JwYy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/portability/api/metrics\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.93% <0.00%> (ø)` | |
| [...hon/apache\_beam/portability/api/beam\_fn\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/external\_transforms\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...m/portability/api/beam\_interactive\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMl9ncnBjLnB5) | `0.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/portability/api/beam\_fn\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_job\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjJfZ3JwYy5weQ==) | `56.98% <0.00%> (ø)` | |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.93% <0.00%> (ø)` | |
| [...eam/portability/api/beam\_expansion\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZXhwYW5zaW9uX2FwaV9wYjJfZ3JwYy5weQ==) | `61.90% <0.00%> (ø)` | |
| [...am/portability/api/external\_transforms\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...m/portability/api/beam\_interactive\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMl9ncnBjLnB5) | `0.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/beam\_job\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...ce8a592](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (766e0eb) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
- Hits 47584 47583 -1
- Misses 9930 9935 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...766e0eb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7223fb3...d14d168](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...e3d2be0](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7223fb3...d3d030a](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847617
##########
File path: sdks/java/testing/kafka-service/build.gradle
##########
@@ -13,7 +13,7 @@
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
- * limitations under the License.
+ * limitations under the License
*/
Review comment:
period removed by mistake. please bring it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (be64412) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47581 -3
- Misses 9930 9933 +3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...aa22d1b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...8b45b0f](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-705752427
What is Nebula plugin? Why does Beam need this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847249
##########
File path: runners/flink/1.12/build.gradle
##########
@@ -17,6 +17,7 @@
*/
def basePath = '..'
+
Review comment:
@sonam-vend this is a stray change. please revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (20703a1) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47594 +10
+ Misses 9930 9924 -6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `92.72% <0.00%> (+1.81%)` | :arrow_up: |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `93.18% <0.00%> (+4.54%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...c207c6a](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752949784
> I didn't have time to go through all of this today. To be honest, I don't think there's any way we can merge a single PR changing the entire project at once. I recommend splitting this PR into separate PRs, one for each module, so that it's easier to review and merge safely.
>
> A couple general comments:
>
> * If a dependency is defined in [project.ext.library](https://github.com/apache/beam/blob/7eacb40ee9591b8133b6017eb72b37702a2b9417/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L460), always use that value instead of hard-coding it. For example, use `library.java.google_oauth_client` instead of `"com.google.oauth-client:google-oauth-client:1.31.0"`.
> * This is purely cosmetic, but try to keep the dependency lists alphabetized. It makes them much easier to read.
@ibzib , I consider it is quite large and critical change to be merged all at once. Responding to your suggestion of splitting this PR into multiple separate PR, I am thinking to split this PR into 8 sub PRs as:
1. Module A | beam/example/java
2. Module B | beam/model
3. Module C | beam/runners/core-construction-java, runners/core-java, runners/direct-java, runners/extensions-java
4. Module D | runners/flink, runners/google-cloud-dataflow-java,runners/google-cloud-dataflow-java, runners/java-fn-execution, runners/java-job-service, runners/jet
5. Module E | runners/local-java, runners/portability, runners/samza, runners/spark, runners/twister2
6. Module F | sdks/java/bom, sdks/java/build-tools, sdks/java/container, sdks/java/core
7. Module G | sdks/java/expansion-service, sdks/java/extensions, sdks/java/fn-execution, sdks/java/harness
8. Module H | sdks/java/io, sdks/java/javadoc, sdks/java/maven-archetypes, sdks/java/testing
See if this proposal looks good to you, or else I welcome your other suggestions.
[BEAM-10961.xlsx](https://github.com/apache/beam/files/5757268/BEAM-10961.xlsx)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...9fa8a1d](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752301262
@kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
(excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/io/gcp/resource\_identifiers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Jlc291cmNlX2lkZW50aWZpZXJzLnB5) | | |
| [sdks/python/apache\_beam/utils/sharded\_key.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmRlZF9rZXkucHk=) | | |
| [...ks/python/apache\_beam/internal/metrics/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9fX2luaXRfXy5weQ==) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend removed a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend removed a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-746080441
Run Java PreCommit"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7223fb3...51e4364](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r539291190
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
project(":runners:flink:1.10") is transitively being declared, though we do not need it here. If I dont add
dependencies {
permitUnusedDeclared project(":runners:flink:1.10")
}
I have been getting,
What went wrong:
Execution failed for task ':runners:flink:1.10:job-server:analyzeClassesDependencies'.
> Dependency analysis found issues.
unusedDeclaredArtifacts:
- beam.runners.flink:1.10:2.27.0-SNAPSHOT@jar
same is true for other versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...a85aab1](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left of the screen and doing some sort/uniq/diff on bash) this is the *only* task that actually gets called twice . Not sure if that's expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test, :runners:flink:1.11:test, :runners:samza:compileTestJava
Could this failure be related to the same test being called more than once in the same runtime instance. Is it worth looking into removing this duplicate calling of tasks? Or maybe there's a simpler answer....
@kennknowles @ibzib
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (766e0eb) into [master](https://codecov.io/gh/apache/beam/commit/cf7431368f932e496afcb3a3063b5cd60c152903?el=desc) (cf74313) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.77% 82.72% -0.05%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47608 47583 -25
- Misses 9910 9935 +25
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.63% <0.00%> (-4.55%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.90% <0.00%> (-1.82%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.28% <0.00%> (-1.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.84%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [2f205f1...7cc00b0](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (ab8fb61) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47582 -2
- Misses 9930 9932 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...be64412](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...e3d2be0](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.73% +47.92%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47585 +28441
+ Misses 35864 9933 -25931
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfZ3JwYy5weQ==) | `80.95% <0.00%> (ø)` | |
| [...beam/portability/api/beam\_artifact\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMl9ncnBjLnB5) | `56.98% <0.00%> (ø)` | |
| [...che\_beam/portability/api/beam\_provision\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcHJvdmlzaW9uX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/external\_transforms\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/portability/api/schema\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3NjaGVtYV9wYjJfZ3JwYy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMl9ncnBjLnB5) | `72.64% <0.00%> (ø)` | |
| ... and [343 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) (3d6cc0e) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [8b4b78e...47c8295](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550447486
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.apache.httpcomponents:httpclient:4.5.13"
+ compile "org.apache.httpcomponents:httpcore:4.4.13"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ compile library.java.vendored_grpc_1_26_0
+ compile "com.github.spotbugs:spotbugs-annotations:3.1.9"
Review comment:
I had no idea about this, thanks!
removed as u suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752949784
> I didn't have time to go through all of this today. To be honest, I don't think there's any way we can merge a single PR changing the entire project at once. I recommend splitting this PR into separate PRs, one for each module, so that it's easier to review and merge safely.
>
> A couple general comments:
>
> * If a dependency is defined in [project.ext.library](https://github.com/apache/beam/blob/7eacb40ee9591b8133b6017eb72b37702a2b9417/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L460), always use that value instead of hard-coding it. For example, use `library.java.google_oauth_client` instead of `"com.google.oauth-client:google-oauth-client:1.31.0"`.
> * This is purely cosmetic, but try to keep the dependency lists alphabetized. It makes them much easier to read.
@ibzib , I consider it is quite large and critical change to be merged all at once. Responding to your suggestion of splitting this PR into multiple separate PR, I am thinking to split this PR into 8 sub PRs as:
1. Module A | beam/example/java
2. Module B | beam/model
3. Module C | beam/runners/core-construction-java, runners/core-java, runners/direct-java, runners/extensions-java
4. Module D | runners/flink, runners/google-cloud-dataflow-java,runners/google-cloud-dataflow-java, runners/java-fn-execution, runners/java-job-service, runners/jet
5. Module E | runners/local-java, runners/portability, runners/samza, runners/spark, runners/twister2
6. Module F | sdks/java/bom, sdks/java/build-tools, sdks/java/container, sdks/java/core
7. Module G | sdks/java/expansion-service, sdks/java/extensions, sdks/java/fn-execution, sdks/java/harness
8. Module H | sdks/java/io, sdks/java/javadoc, sdks/java/maven-archetypes, sdks/java/testing
See if this proposal looks good to you, or else I welcome your other suggestions.
[BEAM-10961.xlsx](https://github.com/apache/beam/files/5757268/BEAM-10961.xlsx)
cc @shehzaadn-vd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550126643
##########
File path: sdks/java/container/license_scripts/dep_urls_java.yaml
##########
@@ -48,5 +48,5 @@ paranamer:
'2.7':
license: "https://raw.githubusercontent.com/paul-hammant/paranamer/master/LICENSE.txt"
xz:
- '1.8':
- license: "https://git.tukaani.org/?p=xz-java.git;a=blob_plain;f=COPYING;h=c1d404dc7a6f06a0437bf1055fedaa4a4c89d728;hb=HEAD"
+ '1.5':
+ license: "https://git.tukaani.org/?p=xz-java.git;a=blob;f=COPYING;h=c1d404dc7a6f06a0437bf1055fedaa4a4c89d728;hb=9f1f97a26f090ffec6568c004a38c6534aa82b94"
Review comment:
For sdks:java:container:pullLicenses to task to succeed, i had to downgrade xz licence version from 1.8 to 1.5 as suggested by the build scan https://scans.gradle.com/s/2tv254pmdrzxq/console-log?task=:sdks:java:container:pullLicenses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847451
##########
File path: sdks/java/build-tools/build.gradle
##########
@@ -20,3 +20,4 @@ plugins { id 'org.apache.beam.module' }
applyJavaNature(exportJavadoc: false, publish: false)
description = "Apache Beam :: SDKs :: Java :: Build Tools"
+
Review comment:
stray blank line - please remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752949784
> I didn't have time to go through all of this today. To be honest, I don't think there's any way we can merge a single PR changing the entire project at once. I recommend splitting this PR into separate PRs, one for each module, so that it's easier to review and merge safely.
>
> A couple general comments:
>
> * If a dependency is defined in [project.ext.library](https://github.com/apache/beam/blob/7eacb40ee9591b8133b6017eb72b37702a2b9417/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L460), always use that value instead of hard-coding it. For example, use `library.java.google_oauth_client` instead of `"com.google.oauth-client:google-oauth-client:1.31.0"`.
> * This is purely cosmetic, but try to keep the dependency lists alphabetized. It makes them much easier to read.
I consider it is quite large and critical change to be merged all at once. Responding to your suggestion of splitting this PR into multiple separate PR, I am thinking to split this PR into 8 sub PRs as:
1. Module A | beam/example/java
2. Module B | beam/model
3. Module C | beam/runners/core-construction-java, runners/core-java, runners/direct-java, runners/extensions-java
4. Module D | runners/flink, runners/google-cloud-dataflow-java,runners/google-cloud-dataflow-java, runners/java-fn-execution, runners/java-job-service, runners/jet
5. Module E | runners/local-java, runners/portability, runners/samza, runners/spark, runners/twister2
6. Module F | sdks/java/bom, sdks/java/build-tools, sdks/java/container, sdks/java/core
7. Module G | sdks/java/expansion-service, sdks/java/extensions, sdks/java/fn-execution, sdks/java/harness
8. Module H | sdks/java/io, sdks/java/javadoc, sdks/java/maven-archetypes, sdks/java/testing
See if this proposal looks good to you, or else I welcome your other suggestions.
[BEAM-10961.xlsx](https://github.com/apache/beam/files/5757268/BEAM-10961.xlsx)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b1cb732) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.80%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.60% +47.80%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47499 +28355
+ Misses 35864 10004 -25860
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <ø> (+42.67%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...b1cb732](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r542289800
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -43,40 +43,13 @@ class GrpcVendoring_1_26_0 {
static def npn_api_version = "1.1.1.v20141010"
static def jboss_marshalling_version = "1.4.11.Final"
static def jboss_modules_version = "1.1.0.Beta1"
-
/** Returns the list of compile time dependencies. */
static List<String> dependencies() {
return [
- "com.google.guava:guava:$guava_version",
Review comment:
Do we need to run this for all the artifacts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b1cb732) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.80%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.60% +47.80%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47499 +28355
+ Misses 35864 10004 -25860
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <ø> (+42.67%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...b1cb732](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/external\_transforms\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...ython/apache\_beam/portability/api/endpoints\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/metrics\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...beam/portability/api/beam\_artifact\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMl91cm5zLnB5) | `0.00% <0.00%> (ø)` | |
| [...m/portability/api/beam\_interactive\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMl9ncnBjLnB5) | `0.00% <0.00%> (ø)` | |
| [...eam/portability/api/beam\_expansion\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZXhwYW5zaW9uX2FwaV9wYjJfZ3JwYy5weQ==) | `61.90% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_job\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjJfZ3JwYy5weQ==) | `56.98% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-743529741
/cc @tysonjh - In case @kennknowles would not have much time for this review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...205d42a](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend removed a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend removed a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-744375442
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550448928
##########
File path: runners/flink/job-server/flink_job_server.gradle
##########
@@ -94,6 +94,7 @@ dependencies {
runtimeOnly project(":sdks:java:io:google-cloud-platform")
// SqlTransform
runtimeOnly project(":sdks:java:extensions:sql:expansion-service")
+ permitUnusedDeclared project(":runners:flink:1.8")
Review comment:
removed it from here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-753873064
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/metrics\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [.../apache\_beam/portability/api/endpoints\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjJfZ3JwYy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...ython/apache\_beam/portability/api/endpoints\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/portability/api/metrics\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_artifact\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...m/portability/api/beam\_interactive\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMl9ncnBjLnB5) | `0.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/external\_transforms\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (be64412) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47581 -3
- Misses 9930 9933 +3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...be64412](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (c207c6a) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 466 466
Lines 57514 57518 +4
=======================================
+ Hits 47584 47589 +5
+ Misses 9930 9929 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...766e0eb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (c207c6a) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 466 466
Lines 57514 57518 +4
=======================================
+ Hits 47584 47589 +5
+ Misses 9930 9929 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...c207c6a](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-748830879
Run Python_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r535252653
##########
File path: runners/flink/1.8/build.gradle
##########
@@ -32,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_clients_version"
+ compile library.java.jackson_databind
+ compile library.java.jsr305
+ compile "org.apache.flink:flink-annotations:$flink_annotations_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_optimizer_version"
+ compile "org.checkerframework:checker-qual:$checker_qual_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf", configuration: "shadow")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Done as per your recommendation :)
##########
File path: runners/flink/1.11/job-server/build.gradle
##########
@@ -29,3 +29,9 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.11")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Done as per your recommendation :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...f73b7e2](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/io/gcp/resource\_identifiers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Jlc291cmNlX2lkZW50aWZpZXJzLnB5) | | |
| [...\_beam/runners/interactive/user\_pipeline\_tracker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91c2VyX3BpcGVsaW5lX3RyYWNrZXIucHk=) | | |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...5dd2771](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/io/gcp/resource\_identifiers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Jlc291cmNlX2lkZW50aWZpZXJzLnB5) | | |
| [...\_beam/runners/interactive/user\_pipeline\_tracker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91c2VyX3BpcGVsaW5lX3RyYWNrZXIucHk=) | | |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...23a5609](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (20703a1) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47594 +10
+ Misses 9930 9924 -6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `92.72% <0.00%> (+1.81%)` | :arrow_up: |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `93.18% <0.00%> (+4.54%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...20703a1](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530545987
##########
File path: model/job-management/build.gradle
##########
@@ -32,4 +32,7 @@ dependencies {
// export the shaded variant as the actual runtime dependency.
compile project(path: ":model:pipeline", configuration: "unshaded")
runtime project(path: ":model:pipeline", configuration: "shadow")
+ permitUnusedDeclared library.java.vendored_grpc_1_26_0
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
+ compile "com.google.guava:guava:28.1-android"
Review comment:
@kennknowles something like, do we need to need to declare it any central location?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/portability/api/beam\_artifact\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMl91cm5zLnB5) | `0.00% <0.00%> (ø)` | |
| [.../apache\_beam/portability/api/endpoints\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjJfZ3JwYy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/metrics\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfZ3JwYy5weQ==) | `80.95% <0.00%> (ø)` | |
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMl9ncnBjLnB5) | `72.64% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_interactive\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_artifact\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...b974636](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (8b45b0f) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47587 +3
+ Misses 9934 9931 -3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.57% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.28% <0.00%> (+0.35%)` | :arrow_up: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...8b45b0f](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.70% -0.03%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47572 -12
- Misses 9934 9946 +12
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (-14.57%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/subprocess\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc3VicHJvY2Vzc19zZXJ2ZXIucHk=) | `53.17% <0.00%> (-0.58%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `94.56% <0.00%> (-0.04%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/core.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb3JlLnB5) | `91.54% <0.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/runners/runner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9ydW5uZXIucHk=) | `74.54% <0.00%> (+0.15%)` | :arrow_up: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.84% <0.00%> (+0.17%)` | :arrow_up: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47585 +1
+ Misses 9934 9933 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.83% <0.00%> (+0.12%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | | |
| [...ks/python/apache\_beam/internal/metrics/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9fX2luaXRfXy5weQ==) | | |
| [.../python/apache\_beam/io/gcp/resource\_identifiers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Jlc291cmNlX2lkZW50aWZpZXJzLnB5) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [31716b0...606e3d5](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530514263
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.10.1"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
Review comment:
Done as per your recommendation :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | | |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | | |
| [...ks/python/apache\_beam/internal/metrics/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9fX2luaXRfXy5weQ==) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [31716b0...c9add73](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-746808612
Run Python_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847740
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -30,12 +30,14 @@ dependencies {
compile project(path: ":sdks:java:core", configuration: "shadow")
compile library.java.vendored_guava_26_0_jre
compile library.java.google_cloud_bigquery
- compile project(":sdks:java:extensions:google-cloud-platform-core")
-
+ compile "com.google.code.gson:gson:2.8.6"
Review comment:
there should be a blank line between compile and testCompile lines - like there was before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r518004743
##########
File path: examples/java/build.gradle
##########
@@ -67,7 +67,11 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile "com.google.code.findbugs:jsr305:3.0.2"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ permitUnusedDeclared "com.google.auto.value:auto-value-annotations:1.7.2"
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
@kennknowles modified almost all the newly added dependencies to the library.auto_value_annotations now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752927775
Run SQL PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847357
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -93,22 +92,26 @@ dependencies {
compile library.java.joda_time
shadow library.java.vendored_guava_26_0_jre
compile library.java.slf4j_api
+ compile "com.google.api.grpc:proto-google-common-protos:1.17.0"
+ permitUnusedDeclared "org.conscrypt:conscrypt-openjdk:1.1.3:linux-x86_64"
compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
+ //compile "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
compile "org.eclipse.jetty:jetty-server:9.2.10.v20150310"
compile "org.eclipse.jetty:jetty-servlet:9.2.10.v20150310"
- compile library.java.error_prone_annotations
+ compile "com.google.auth:google-auth-library-credentials:0.19.0"
+ compile "com.google.guava:guava:25.1-jre"
+ compile "io.opencensus:opencensus-api:0.24.0"
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.conscrypt:conscrypt-openjdk-uber:2.2.1"
compile library.java.slf4j_jdk14
-
+ permitUnusedDeclared library.java.slf4j_jdk14
Review comment:
nitpick - there should be a be a blank line about the comment - like there was before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550132929
##########
File path: sdks/java/container/license_scripts/dep_urls_java.yaml
##########
@@ -48,5 +48,5 @@ paranamer:
'2.7':
license: "https://raw.githubusercontent.com/paul-hammant/paranamer/master/LICENSE.txt"
xz:
- '1.8':
- license: "https://git.tukaani.org/?p=xz-java.git;a=blob_plain;f=COPYING;h=c1d404dc7a6f06a0437bf1055fedaa4a4c89d728;hb=HEAD"
+ '1.5':
+ license: "https://git.tukaani.org/?p=xz-java.git;a=blob;f=COPYING;h=c1d404dc7a6f06a0437bf1055fedaa4a4c89d728;hb=9f1f97a26f090ffec6568c004a38c6534aa82b94"
Review comment:
For `sdks:java:container:pullLicenses` task to succeed, i had to downgrade xz licence version from 1.8 to 1.5 as suggested by the build scan https://scans.gradle.com/s/2tv254pmdrzxq/console-log?task=:sdks:java:container:pullLicenses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847287
##########
File path: runners/flink/1.9/build.gradle
##########
@@ -31,3 +32,4 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
Review comment:
stray change - please revert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [64ec3da...e73cdf0](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (9a773af) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47595 +11
+ Misses 9930 9923 -7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.11% <0.00%> (+2.20%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...9a773af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...b23845d](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...les/complete/juliaset/juliaset/juliaset\_test\_it.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvanVsaWFzZXRfdGVzdF9pdC5weQ==) | | |
| [sdks/python/apache\_beam/internal/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9jZWxscy5weQ==) | | |
| [sdks/python/apache\_beam/utils/sentinel.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2VudGluZWwucHk=) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...7721512](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-705752427
What is Nebula plugin? Why does Beam need this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend closed pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend closed pull request #12938:
URL: https://github.com/apache/beam/pull/12938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847556
##########
File path: sdks/java/io/kinesis/expansion-service/build.gradle
##########
@@ -32,7 +32,6 @@ description = "Apache Beam :: SDKs :: Java :: IO :: Kinesis :: Expansion Service
ext.summary = "Expansion service serving KinesisIO"
dependencies {
- compile project(":sdks:java:expansion-service")
- compile project(":sdks:java:io:kinesis")
runtime library.java.slf4j_jdk14
}
+
Review comment:
stray blank line - please remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-744430001
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (c207c6a) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 466 466
Lines 57514 57518 +4
=======================================
+ Hits 47584 47589 +5
+ Misses 9930 9929 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...c207c6a](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550447382
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
Review comment:
Thanks for guidance here, resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (766e0eb) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
- Hits 47584 47583 -1
- Misses 9930 9935 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...766e0eb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847683
##########
File path: sdks/java/testing/load-tests/build.gradle
##########
@@ -63,13 +63,17 @@ dependencies {
compile library.java.kafka_clients
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":runners:direct-java", configuration: "shadow")
compile project(":sdks:java:io:synthetic")
compile project(":sdks:java:testing:test-utils")
compile project(":sdks:java:io:google-cloud-platform")
compile project(":sdks:java:io:kafka")
compile project(":sdks:java:io:kinesis")
-
Review comment:
there should be an empty line between "compile" and "gradleRun" lines - like there was before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left and doing some sort/uniq/diff on bash) this is the *only* task that actually gets called twice . Not sure if that's expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test, :runners:flink:1.11:test, :runners:samza:compileTestJava
Could this failure be related to the same test being called more than once in the same runtime instance. Is it worth looking into removing this duplicate calling of tasks? Or maybe there's a simpler answer....
@kennknowles @ibzib
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550367164
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
Review comment:
(This will allow you to remove the spotbugs dependency.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (766e0eb) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
- Hits 47584 47583 -1
- Misses 9930 9935 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...766e0eb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-721053627
R: @reuvenlax @kennknowles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r516544404
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -95,7 +90,7 @@ class BeamModulePlugin implements Plugin<Project> {
boolean ignoreRawtypeErrors = false
/** Controls whether the dependency analysis plugin is enabled. */
- boolean enableStrictDependencies = false
+ boolean enableStrictDependencies = true
Review comment:
enabled dependency check via wfhartford plugin
##########
File path: examples/java/build.gradle
##########
@@ -67,7 +67,11 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile "com.google.code.findbugs:jsr305:3.0.2"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ permitUnusedDeclared "com.google.auto.value:auto-value-annotations:1.7.2"
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Adding dependencies to permitUnusedDeclared or permitTestUnusedDeclared causes the dependency analyzer to ignore cases where the dependencies are declared but not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-738595171
> Some big picture items:
>
> * when we have an exclusion from dependency analysis, we need a comment about why
> * library versions are centrally managed
1. Places where ./gradlew analyzeDependencies gives UnusedDeclared, i have excluded those dependencies.
2. I have moved dependencies to the central place where possible like for flink runner. However, where modules need different versions of the same dependency, I have placed to that module only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-747142004
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [4619286...accf6e7](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (c207c6a) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 466 466
Lines 57514 57518 +4
=======================================
+ Hits 47584 47589 +5
+ Misses 9930 9929 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...c207c6a](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (be64412) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47581 -3
- Misses 9930 9933 +3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...be64412](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (be64412) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47581 -3
- Misses 9930 9933 +3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...be64412](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left and doing some sort/uniq/diff on bash) this is the only task that actually gets called twice . Not sure if that's expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test, :runners:flink:1.11:test, :runners:samza:compileTestJava
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) (3d6cc0e) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [8b4b78e...0b42185](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (aa22d1b) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47587 +3
- Misses 9930 9931 +1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.31% <0.00%> (-0.52%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.57% <0.00%> (+0.24%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `89.63% <0.00%> (+1.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...aa22d1b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r518021372
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -26,57 +26,14 @@ class GrpcVendoring_1_26_0 {
static def guava_version = "26.0-jre"
static def protobuf_version = "3.11.0"
static def grpc_version = "1.26.0"
- static def gson_version = "2.8.6"
Review comment:
analyzeDependencies using wfhartford plugin suggests these dependencies are not required by any module of the Project. So must be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (aa22d1b) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47587 +3
- Misses 9930 9931 +1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.31% <0.00%> (-0.52%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.57% <0.00%> (+0.24%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `89.63% <0.00%> (+1.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...aa22d1b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) (3d6cc0e) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [8b4b78e...16d46ad](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...aae94a7](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (ab8fb61) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47582 -2
- Misses 9930 9932 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...ab8fb61](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b1cb732) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.80%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.60% +47.80%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47499 +28355
+ Misses 35864 10004 -25860
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <ø> (+42.67%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530330061
##########
File path: runners/flink/1.9/job-server/build.gradle
##########
@@ -29,3 +29,8 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.9")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
@mxm ,moved checker-qual to flink_job_server.gradle file. Cannot move the other one since its version specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left of the screen and doing some sort/uniq/diff on bash) this is being executed multiple times. Not sure if that's expected. Other such tasks are: :runners:google-cloud-dataflow-java:compileTestJava, :runners:google-cloud-dataflow-java:worker:compileJava, :runners:google-cloud-dataflow-java:worker:compileTestJava, :runners:google-cloud-dataflow-java:worker:legacy-worker:compileJava, :runners:google-cloud-dataflow-java:worker:legacy-worker:compileTestJava, :sdks:go:resolveBuildDependencies, :sdks:java:extensions:sql:compileTestJava. These others might be harmless.
3) In this build (#15307), we have a much larger number of tasks that are being executed multiple times..
Could this failure be related to the same test being called more than once in the same runtime instance. Is it worth looking into removing this duplicate calling of tasks? Or maybe there's a simpler answer....
Or, separately, should the excudeTestsMatching clauses that are in portabilility/build.gradle (as part of PR https://github.com/apache/beam/pull/11792) also be added to direct-java/build.gradle?
@kennknowles @ibzib
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r518019727
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,13 @@
*/
def basePath = '..'
+def jackson_annotations_version = "2.10.2"
+def flink_clients_version = "1.10.1"
+def jackson_databind_verisioon = "2.10.2"
+def jsr305_version = "3.0.2"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
+def checker_qual_version = "2.0.0"
Review comment:
Flink 1.8 needs :
def flink_clients_version = "1.8.3"
def flink_annotations_version = "1.8.3"
def flink_optimizer_version = "1.8.3"
Flink 1.9 needs:
def flink_clients_version = "1.9.3"
def flink_annotations_version = "1.9.3"
def flink_optimizer_version = "1.9.3"
Same is true for flink 1.10 and 1.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r518005812
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,13 @@
*/
def basePath = '..'
+def jackson_annotations_version = "2.10.2"
+def flink_clients_version = "1.10.1"
+def jackson_databind_verisioon = "2.10.2"
Review comment:
fixed it by library.java.jackson_databind. Now we no longer need version declaration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r518004743
##########
File path: examples/java/build.gradle
##########
@@ -67,7 +67,11 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile "com.google.code.findbugs:jsr305:3.0.2"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ permitUnusedDeclared "com.google.auto.value:auto-value-annotations:1.7.2"
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
@kennknowles modified almost all the newly added dependencies to the "library.auto_value_annotations" format now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [4619286...40f04af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...872b9df](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) (3d6cc0e) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [8b4b78e...0a31ca4](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.58% -0.15%
==========================================
Files 466 466
Lines 57514 57503 -11
==========================================
- Hits 47584 47491 -93
- Misses 9930 10012 +82
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (-14.57%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/userstate.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91c2Vyc3RhdGUucHk=) | `82.18% <0.00%> (-2.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/core.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb3JlLnB5) | `88.92% <0.00%> (-2.59%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `88.88% <0.00%> (-1.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <0.00%> (-1.29%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `84.17% <0.00%> (-0.98%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/ptransform.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5) | `92.02% <0.00%> (-0.94%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.49% <0.00%> (-0.84%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...ab8fb61](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (7cc00b0) into [master](https://codecov.io/gh/apache/beam/commit/2f205f100f2180665d6373d427a29b57cde00bc1?el=desc) (2f205f1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.73% 82.74%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47587 47591 +4
+ Misses 9931 9927 -4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.29% <0.00%> (-0.53%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.83% <0.00%> (+0.12%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.41%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [2f205f1...7cc00b0](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (be64412) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47581 -3
- Misses 9930 9933 +3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...be64412](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-744375442
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [64ec3da...907544f](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (7cc00b0) into [master](https://codecov.io/gh/apache/beam/commit/2f205f100f2180665d6373d427a29b57cde00bc1?el=desc) (2f205f1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.73% 82.74%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47587 47591 +4
+ Misses 9931 9927 -4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.29% <0.00%> (-0.53%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.83% <0.00%> (+0.12%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.41%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [2f205f1...7cc00b0](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (20703a1) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47594 +10
+ Misses 9930 9924 -6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `92.72% <0.00%> (+1.81%)` | :arrow_up: |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `93.18% <0.00%> (+4.54%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...20703a1](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7223fb3...d08dbd9](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-746090811
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r537730018
##########
File path: runners/core-construction-java/build.gradle
##########
@@ -60,8 +60,9 @@ dependencies {
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.slf4j_api
- testCompile library.java.hamcrest_core
- testCompile library.java.hamcrest_library
+ compile "com.fasterxml.jackson.core:jackson-annotations:2.10.2"
Review comment:
Should be `library.jackson_core` etc
##########
File path: runners/core-java/build.gradle
##########
@@ -41,17 +41,17 @@ test {
dependencies {
compile project(path: ":model:pipeline", configuration: "shadow")
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
compile project(":runners:core-construction-java")
- compile project(":sdks:java:fn-execution")
+ permitUsedUndeclared project(":sdks:java:fn-execution")
Review comment:
We should not need `permitUsedDeclared` for this. It seems like it was OK before. Otherwise at least it would be `runtime`.
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
This seems strange. The Flink 1.10 job server should definitely actually use `:runners:flink:1.10`. And same for the other versions. Why is this needed?
##########
File path: runners/direct-java/build.gradle
##########
@@ -70,17 +71,16 @@ dependencies {
shadow library.java.vendored_grpc_1_26_0
shadow library.java.joda_time
shadow library.java.slf4j_api
- shadow library.java.args4j
+ permitUnusedDeclared "org.apache.beam:beam-vendor-grpc-1_26_0:0.3"
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
Transitive dependencies are automatically included. So there is something else that makes these transitive dependencies not work. If the compile step succeeds but the test step does not succeed, that means it is a runtime dependency of the test. I think the only thing we can do is to add the exclusion, for now. Please add a comment that these are runtime dependencies of the tests.
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -43,40 +43,13 @@ class GrpcVendoring_1_26_0 {
static def npn_api_version = "1.1.1.v20141010"
static def jboss_marshalling_version = "1.4.11.Final"
static def jboss_modules_version = "1.1.0.Beta1"
-
/** Returns the list of compile time dependencies. */
static List<String> dependencies() {
return [
- "com.google.guava:guava:$guava_version",
Review comment:
It is not quite so simple. See https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades
Specifically,
./gradlew -Ppublishing -PjavaLinkageArtifactIds=beam-vendor-grpc-1_26_0 :checkJavaLinkage
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -850,7 +849,7 @@ class BeamModulePlugin implements Plugin<Project> {
// configurations because they are never required to be shaded or become a
// dependency of the output.
def compileOnlyAnnotationDeps = [
- "com.google.auto.value:auto-value-annotations:1.7",
+ "com.google.auto.value:auto-value-annotations:1.7.2",
Review comment:
You gave a thumbs up but did not add the lines here :-)
Here is what I mean: Right now you have this line in many `build.gradle` files:
permitUnusedDeclared "com.google.auto.value:auto-value-annotations:1.7.2"
Instead, move that line here. This way the `build.gradle` files are cleaner and do not have to have exclusions for things they do not control.
##########
File path: runners/google-cloud-dataflow-java/worker/windmill/build.gradle
##########
@@ -36,3 +36,9 @@ configurations {
artifacts {
unshaded jar
}
+
+dependencies {
+ compile "com.google.guava:guava:28.1-android"
Review comment:
This should be `library.guava` (here and everywhere)
If that version doesn't work, we need to know why.
##########
File path: sdks/java/io/file-based-io-tests/build.gradle
##########
@@ -31,8 +31,7 @@ dependencies {
testCompile project(path: ":sdks:java:io:parquet", configuration: "testRuntime")
testCompile project(path: ":sdks:java:testing:test-utils", configuration: "testRuntime")
testCompile library.java.jaxb_api
- testCompile library.java.jaxb_impl
testCompile library.java.junit
- testCompile library.java.hamcrest_core
testCompile library.java.hadoop_client
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Choosing one file at random to comment on: do this in BeamModulePlugin not in every build.gradle file.
##########
File path: examples/java/build.gradle
##########
@@ -67,7 +67,11 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile "com.google.code.findbugs:jsr305:3.0.2"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ permitUnusedDeclared "com.google.auto.value:auto-value-annotations:1.7.2"
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
... but not this one?
I wonder if you forgot to push the new commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752404922
Re: my last pair of comments: It looks like running Run Java PreCommit again fixed the issue - which suggests the test is a bit unstable, but unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/transforms/combinefn\_lifecycle\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lZm5fbGlmZWN5Y2xlX3BpcGVsaW5lLnB5) | | |
| [sdks/python/apache\_beam/utils/sharded\_key.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmRlZF9rZXkucHk=) | | |
| [sdks/python/apache\_beam/internal/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9jZWxscy5weQ==) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...c27ae5e](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847398
##########
File path: runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
##########
@@ -213,12 +212,21 @@ dependencies {
compile project(":sdks:java:fn-execution")
compile project(path: ":runners:google-cloud-dataflow-java:worker:windmill", configuration: "shadow")
shadow library.java.vendored_guava_26_0_jre
- compile "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
compile "org.eclipse.jetty:jetty-server:9.2.10.v20150310"
compile "org.eclipse.jetty:jetty-servlet:9.2.10.v20150310"
- provided library.java.error_prone_annotations
runtime library.java.slf4j_jdk14
-
Review comment:
nitpick - there should be blank line above the comment like before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (7cc00b0) into [master](https://codecov.io/gh/apache/beam/commit/2f205f100f2180665d6373d427a29b57cde00bc1?el=desc) (2f205f1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.73% 82.74%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47587 47591 +4
+ Misses 9931 9927 -4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.29% <0.00%> (-0.53%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.83% <0.00%> (+0.12%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.41%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [2f205f1...7cc00b0](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-746735017
Run PythonLint PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550304725
##########
File path: runners/flink/1.8/build.gradle
##########
@@ -17,7 +17,6 @@
*/
def basePath = '..'
-
Review comment:
Please revert this change.
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -40,13 +40,13 @@ applyJavaNature(
// In the case of the Fn API worker jar we are creating an application so we rely on
// the shadow plugin to include all transitive dependencies to create an uber jar.
- // Include original source files extracted under
- // '$buildDir/original_sources_to_package' to jar
- from "$buildDir/original_sources_to_package"
+ // Include original source files extracted under
Review comment:
Please revert these indentation changes.
##########
File path: sdks/java/testing/kafka-service/build.gradle
##########
@@ -13,7 +13,7 @@
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
- * limitations under the License.
+ * limitations under the License.dependencies
Review comment:
Please revert this change.
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
Review comment:
Don't add jsr305 as a compile dependency; it should be a compileOnly dependency. Also, since the transitive dependency on jsr305 is introduced by `spotBugs`, jsr305 should be included in `compileOnlyAnnotationDeps`. Including jsr305 in `compileOnlyAnnotationDeps` will remove the need to add it in every build file.
##########
File path: runners/flink/job-server/flink_job_server.gradle
##########
@@ -94,6 +94,7 @@ dependencies {
runtimeOnly project(":sdks:java:io:google-cloud-platform")
// SqlTransform
runtimeOnly project(":sdks:java:extensions:sql:expansion-service")
+ permitUnusedDeclared project(":runners:flink:1.8")
Review comment:
Didn't you already do this in `runners/flink/1.8/job-server/build.gradle`?
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
Review comment:
You will need to exclude Zookeeper from kafka-avro-serializer like we do for other Kafka dependencies in `sdks/java/io/kafka/build.gradle`.
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
Can you add a comment explaining that?
##########
File path: sdks/java/javadoc/build.gradle
##########
@@ -84,3 +84,4 @@ task aggregateJavadoc(type: Javadoc) {
}
}
}
+
Review comment:
Please revert this change.
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.apache.httpcomponents:httpclient:4.5.13"
+ compile "org.apache.httpcomponents:httpcore:4.4.13"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ compile library.java.vendored_grpc_1_26_0
+ compile "com.github.spotbugs:spotbugs-annotations:3.1.9"
Review comment:
Spotbugs has an LGPL license, so it's not allowed to be included in Beam as a compile dependency. Remove it.
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.apache.httpcomponents:httpclient:4.5.13"
+ compile "org.apache.httpcomponents:httpcore:4.4.13"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
Review comment:
Use `library.java.google_oauth_client` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (aa22d1b) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47587 +3
- Misses 9930 9931 +1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.31% <0.00%> (-0.52%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.57% <0.00%> (+0.24%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `89.63% <0.00%> (+1.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...aa22d1b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...b1cb732](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752383928
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [64ec3da...a6ed6cb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r518023830
##########
File path: runners/direct-java/build.gradle
##########
@@ -70,17 +71,16 @@ dependencies {
shadow library.java.vendored_grpc_1_26_0
shadow library.java.joda_time
shadow library.java.slf4j_api
- shadow library.java.args4j
+ permitUnusedDeclared "org.apache.beam:beam-vendor-grpc-1_26_0:0.3"
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
If we completely remove these project-project dependencies, Java Wordcount Direct Runner check is failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-744656957
Run Python_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...eam/portability/api/beam\_provision\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcHJvdmlzaW9uX2FwaV9wYjJfZ3JwYy5weQ==) | `76.19% <0.00%> (ø)` | |
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMl9ncnBjLnB5) | `72.64% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfZ3JwYy5weQ==) | `80.95% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/metrics\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/metrics\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_interactive\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...che\_beam/portability/api/beam\_provision\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcHJvdmlzaW9uX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...bb67adb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (9a773af) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47595 +11
+ Misses 9930 9923 -7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.98% <0.00%> (+0.66%)` | :arrow_up: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.11% <0.00%> (+2.20%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...9a773af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r539285857
##########
File path: sdks/java/io/file-based-io-tests/build.gradle
##########
@@ -31,8 +31,7 @@ dependencies {
testCompile project(path: ":sdks:java:io:parquet", configuration: "testRuntime")
testCompile project(path: ":sdks:java:testing:test-utils", configuration: "testRuntime")
testCompile library.java.jaxb_api
- testCompile library.java.jaxb_impl
testCompile library.java.junit
- testCompile library.java.hamcrest_core
testCompile library.java.hadoop_client
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
I had no idea about this, it works like magic! :D a lot of repeated stuff got removed. Thanks for this recommendation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47585 +1
+ Misses 9934 9933 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.83% <0.00%> (+0.12%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r516882760
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -21,27 +21,22 @@ package org.apache.beam.gradle
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
import groovy.json.JsonOutput
import groovy.json.JsonSlurper
-import org.gradle.api.attributes.Category
import org.gradle.api.GradleException
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.Task
import org.gradle.api.artifacts.Configuration
import org.gradle.api.artifacts.ProjectDependency
+import org.gradle.api.attributes.Category
import org.gradle.api.file.FileCollection
import org.gradle.api.file.FileTree
import org.gradle.api.plugins.quality.Checkstyle
import org.gradle.api.publish.maven.MavenPublication
-import org.gradle.api.tasks.Copy
-import org.gradle.api.tasks.Delete
-import org.gradle.api.tasks.Exec
-import org.gradle.api.tasks.JavaExec
+import org.gradle.api.tasks.*
Review comment:
We prefer to not use `*` imports
##########
File path: runners/direct-java/build.gradle
##########
@@ -70,17 +71,16 @@ dependencies {
shadow library.java.vendored_grpc_1_26_0
shadow library.java.joda_time
shadow library.java.slf4j_api
- shadow library.java.args4j
+ permitUnusedDeclared "org.apache.beam:beam-vendor-grpc-1_26_0:0.3"
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
These seem wrong. The direct runner should either use these or not depend on them.
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -95,7 +90,7 @@ class BeamModulePlugin implements Plugin<Project> {
boolean ignoreRawtypeErrors = false
/** Controls whether the dependency analysis plugin is enabled. */
- boolean enableStrictDependencies = false
+ boolean enableStrictDependencies = true
Review comment:
Great. Once it is enabled we can delete the option, too.
##########
File path: examples/java/build.gradle
##########
@@ -67,7 +67,11 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile "com.google.code.findbugs:jsr305:3.0.2"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ permitUnusedDeclared "com.google.auto.value:auto-value-annotations:1.7.2"
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
We prefer to use references to `library.auto_value_annotations`, etc. You may have to add some.
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -31,3 +38,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared "com.fasterxml.jackson.core:jackson-annotations:$jackson_annotations_version"
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_clients_version"
+ compile "com.fasterxml.jackson.core:jackson-databind:$jackson_databind_verisioon"
+ compile "com.google.code.findbugs:jsr305:$jsr305_version"
+ compile "org.apache.flink:flink-annotations:$flink_annotations_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_optimizer_version"
+ compile "org.checkerframework:checker-qual:$checker_qual_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf", configuration: "shadow")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
There should not be an unused declared dep but also an added 2.0.0 dep.
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,13 @@
*/
def basePath = '..'
+def jackson_annotations_version = "2.10.2"
+def flink_clients_version = "1.10.1"
+def jackson_databind_verisioon = "2.10.2"
+def jsr305_version = "3.0.2"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
+def checker_qual_version = "2.0.0"
Review comment:
This version should match the same version as all the other modules unless there is a reason to diverge. It is already added to every Java module by `BeamModulePlugin`.
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -26,57 +26,14 @@ class GrpcVendoring_1_26_0 {
static def guava_version = "26.0-jre"
static def protobuf_version = "3.11.0"
static def grpc_version = "1.26.0"
- static def gson_version = "2.8.6"
Review comment:
I don't understand these deletions
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,13 @@
*/
def basePath = '..'
+def jackson_annotations_version = "2.10.2"
+def flink_clients_version = "1.10.1"
+def jackson_databind_verisioon = "2.10.2"
Review comment:
If the version is different between of Flink 1.10 then it could be listed here, but needs a comment to explain it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (8b45b0f) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47587 +3
+ Misses 9934 9931 -3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.57% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.28% <0.00%> (+0.35%)` | :arrow_up: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...dfd8538](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
mxm commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530227909
##########
File path: gradle.properties
##########
@@ -31,3 +31,6 @@ javaVersion=1.8
docker_image_default_repo_root=apache
docker_image_default_repo_prefix=beam_
+
+org.gradle.daemon=false
Review comment:
Why disable the daemon?
##########
File path: runners/flink/1.11/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.11.1"
+def flink_annotations_version = "1.11.1"
+def flink_optimizer_version = "1.11.1"
Review comment:
Same here, one version variable is enough. Would be good to infer it from the Flink project files.
##########
File path: runners/flink/1.8/job-server/build.gradle
##########
@@ -29,3 +29,8 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.8")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Could we move those into `flink_job_server.gradle`?
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.10.1"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
Review comment:
This should just be `flink_version`, no need to break this down into separate version as different versions are generally not compatible with each other.
##########
File path: runners/flink/1.11/job-server/build.gradle
##########
@@ -29,3 +29,9 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.11")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Same here.
##########
File path: runners/flink/1.9/job-server/build.gradle
##########
@@ -29,3 +29,8 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.9")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Same here.
##########
File path: runners/flink/1.8/build.gradle
##########
@@ -32,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_clients_version"
+ compile library.java.jackson_databind
+ compile library.java.jsr305
+ compile "org.apache.flink:flink-annotations:$flink_annotations_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_optimizer_version"
+ compile "org.checkerframework:checker-qual:$checker_qual_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf", configuration: "shadow")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Could we move those into `flink_runner.gradle`?
##########
File path: runners/flink/1.11/build.gradle
##########
@@ -31,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_clients_version"
Review comment:
This could be true because we often submit only against embedded clusters. However, if you look at `FlinkSubmissionTest`, it definitely utilizes the client dependency through the use of Clifrontend (part of flink-clients).
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.10.1"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
Review comment:
Would be good to infer the version from the Flink project files.
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -31,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
Review comment:
Would be good if shared dependencies across different Flink versions would remain in `flink_runner.gradle`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r549468509
##########
File path: .gitignore
##########
@@ -1,98 +0,0 @@
-# NOTE: if you modify this file, you probably need to modify the file set that
Review comment:
You need to revert the deletion of this file. It is probably the cause of the error in `beam_PreCommit_Go_Phrase`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_artifact\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_job\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjJfZ3JwYy5weQ==) | `56.98% <0.00%> (ø)` | |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.93% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_interactive\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/portability/api/beam\_fn\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/standard\_window\_fns\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/portability/api/external\_transforms\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r518023830
##########
File path: runners/direct-java/build.gradle
##########
@@ -70,17 +71,16 @@ dependencies {
shadow library.java.vendored_grpc_1_26_0
shadow library.java.joda_time
shadow library.java.slf4j_api
- shadow library.java.args4j
+ permitUnusedDeclared "org.apache.beam:beam-vendor-grpc-1_26_0:0.3"
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
If we completely remove these project-project dependencies, Java Wordcount Direct Runner check if failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (766e0eb) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
- Hits 47584 47583 -1
- Misses 9930 9935 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...766e0eb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #12938: [BEAM-10961] Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-920397358
This PR was broken up and merged in parts. See BEAM-10961 for the full list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b1cb732) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.80%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.60% +47.80%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47499 +28355
+ Misses 35864 10004 -25860
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <ø> (+42.67%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...168ec17](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...ython/apache\_beam/portability/api/endpoints\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...che\_beam/portability/api/beam\_expansion\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZXhwYW5zaW9uX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.93% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/beam\_job\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...e\_beam/portability/api/beam\_interactive\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...ache\_beam/portability/api/beam\_artifact\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fYXJ0aWZhY3RfYXBpX3BiMi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/external\_transforms\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [...m/portability/api/beam\_interactive\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMl9ncnBjLnB5) | `0.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b8f78ed) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 466 466
Lines 57518 57518
==========================================
- Hits 47584 47580 -4
- Misses 9934 9938 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.90% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r529728646
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -850,7 +849,7 @@ class BeamModulePlugin implements Plugin<Project> {
// configurations because they are never required to be shaded or become a
// dependency of the output.
def compileOnlyAnnotationDeps = [
- "com.google.auto.value:auto-value-annotations:1.7",
+ "com.google.auto.value:auto-value-annotations:1.7.2",
Review comment:
Around here, you can add these dependencies to `permitUnusedDeclared` so you don't have to add it to all modules.
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -43,40 +43,13 @@ class GrpcVendoring_1_26_0 {
static def npn_api_version = "1.1.1.v20141010"
static def jboss_marshalling_version = "1.4.11.Final"
static def jboss_modules_version = "1.1.0.Beta1"
-
/** Returns the list of compile time dependencies. */
static List<String> dependencies() {
return [
- "com.google.guava:guava:$guava_version",
Review comment:
The change here concerns me - does it introduce linkage errors?
##########
File path: sdks/java/extensions/sql/zetasql/build.gradle
##########
@@ -31,25 +31,24 @@ def zetasql_version = "2020.10.1"
dependencies {
compile enforcedPlatform(library.java.google_cloud_platform_libraries_bom)
- compile project(":sdks:java:core")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
Review comment:
This is a major change.
CC @apilloud for whether it is right
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -71,7 +70,15 @@ dependencies {
compile "com.alibaba:fastjson:1.2.69"
compile "org.codehaus.janino:janino:3.0.11"
compile "org.codehaus.janino:commons-compiler:3.0.11"
- provided "org.checkerframework:checker-qual:3.4.1"
+ compile library.java.jackson_core
+ compile library.java.jsr305
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.mongodb:mongo-java-driver:3.9.1"
+ compile "org.slf4j:slf4j-api:1.7.30"
+ compile "org.apache.beam:beam-vendor-guava-26_0-jre:0.1"
Review comment:
You already have `library.vendored_guava_26_0_jre` below. That should be the only one.
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,13 @@
*/
def basePath = '..'
+def jackson_annotations_version = "2.10.2"
+def flink_clients_version = "1.10.1"
+def jackson_databind_verisioon = "2.10.2"
+def jsr305_version = "3.0.2"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
+def checker_qual_version = "2.0.0"
Review comment:
I meant my comment just on the checker qual version.
##########
File path: model/job-management/build.gradle
##########
@@ -32,4 +32,7 @@ dependencies {
// export the shaded variant as the actual runtime dependency.
compile project(path: ":model:pipeline", configuration: "unshaded")
runtime project(path: ":model:pipeline", configuration: "shadow")
+ permitUnusedDeclared library.java.vendored_grpc_1_26_0
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
+ compile "com.google.guava:guava:28.1-android"
Review comment:
This is interesting. If generated protos depend on this version of Guava, we may need to do something about it.
##########
File path: sdks/java/extensions/sorter/build.gradle
##########
@@ -36,10 +36,10 @@ hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
compile project(path: ":sdks:java:core", configuration: "shadow")
compile library.java.vendored_guava_26_0_jre
+ compile library.java.jsr305
+ compile "org.slf4j:slf4j-api:1.7.30"
Review comment:
This should be `library.slf4j_api` and please set up the version in `BeamModulePlugin.groovy`. The same for all libraries.
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -31,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
Review comment:
The dependencies are set up in `flink_runner.gradle` using the versions in the `project.ext` block.
@mxm may have some comment or recommend someone for a comment.
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.10.1"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
Review comment:
These flink versions are set up just below here in the `project.ext` section.
@mxm may have some comment or recommend someone for a comment.
##########
File path: runners/flink/1.11/build.gradle
##########
@@ -31,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_clients_version"
Review comment:
I don't understand how the flink client is unused. Please add a comment to explain each exclusion. We can try to ask people to understand.
##########
File path: runners/direct-java/build.gradle
##########
@@ -70,17 +71,16 @@ dependencies {
shadow library.java.vendored_grpc_1_26_0
shadow library.java.joda_time
shadow library.java.slf4j_api
- shadow library.java.args4j
+ permitUnusedDeclared "org.apache.beam:beam-vendor-grpc-1_26_0:0.3"
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
I see. So these are really `testRuntime` dependencies. If we had a `shadowTestRuntime` configuration we would exclude it from checking I guess. Since we created the `shadowTest` configuration I don't think there is a `shadowTestRuntime` configuration. Please add a comment explaining these exclusions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...6ef876f](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: Integrated Nebula plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d1261ad2c183f065fe907f1d3f8b1adaac8e81f8?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.32% 82.50% +0.18%
==========================================
Files 455 453 -2
Lines 54603 54610 +7
==========================================
+ Hits 44950 45058 +108
+ Misses 9653 9552 -101
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.76% <0.00%> (-1.03%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `80.23% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `88.35% <0.00%> (-0.15%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.80% <0.00%> (-0.05%)` | :arrow_down: |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.21% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d1261ad...dffde94](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (aa22d1b) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
+ Hits 47584 47587 +3
- Misses 9930 9931 +1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `88.09% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.31% <0.00%> (-0.52%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.57% <0.00%> (+0.24%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `89.63% <0.00%> (+1.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...9a773af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left of the screen and doing some sort/uniq/diff on bash) this is the *only* task that actually gets called twice . Not sure if that's expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test, :runners:flink:1.11:test, :runners:samza:compileTestJava
Could this failure be related to the same test being called more than once in the same runtime instance. Is it worth looking into removing this duplicate calling of tasks? Or maybe there's a simpler answer....
Or, separately, should the excudeTestsMatching clauses that are in portabilility/build.gradle (as part of PR https://github.com/apache/beam/pull/11792) also be added to direct-java/build.gradle?
@kennknowles @ibzib
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847526
##########
File path: sdks/java/io/hadoop-format/build.gradle
##########
@@ -68,6 +69,8 @@ dependencies {
testCompile project(path: ":sdks:java:testing:test-utils", configuration: "testRuntime")
testCompile project(":sdks:java:io:jdbc")
testCompile project(path: ":examples:java", configuration: "testRuntime")
+
Review comment:
stray blank line - please remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-744605777
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b1cb732) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.80%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.60% +47.80%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47499 +28355
+ Misses 35864 10004 -25860
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <ø> (+42.67%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...b1cb732](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550450329
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
`:runners:flink:1.10:job-server:analyzeClassesDependencies `task fails if we don't add `permitUnusedDeclared project(":runners:flink:1.10")`
```
Task :runners:flink:1.10:job-server:analyzeClassesDependencies FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':runners:flink:1.10:job-server:analyzeClassesDependencies'.
> Dependency analysis found issues.
unusedDeclaredArtifacts:
- beam.runners.flink:1.10:2.28.0-SNAPSHOT@jar
```
As it is transitively being declared, but we do not need it here. Thats why it is important to declare it permitUnsedDeclared.
@ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement is showing up as failing even though it's excluded from running in beam/runners/portability/java/build.gradle
> (excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is :runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306), (taking the listing of tasks on the left of the screen and doing some sort/uniq/diff on bash) this is the *only* task that actually gets called twice . Not sure if that's expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test, :runners:flink:1.11:test, :runners:samza:compileTestJava
Could this failure be related to the same test being called more than once in the same runtime instance. Is it worth looking into removing this duplicate calling of tasks? Or maybe there's a simpler answer....
Or, separately, should the excudeTestsMatching clauses that are in portabilility/build.gradle (as part of https://github.com/apache/beam/pull/11792) also be added to direct-java/build.gradle?
@kennknowles @ibzib
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-747141959
Run Python_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530547307
##########
File path: runners/direct-java/build.gradle
##########
@@ -70,17 +71,16 @@ dependencies {
shadow library.java.vendored_grpc_1_26_0
shadow library.java.joda_time
shadow library.java.slf4j_api
- shadow library.java.args4j
+ permitUnusedDeclared "org.apache.beam:beam-vendor-grpc-1_26_0:0.3"
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
@kennknowles , these dependency are indirectly being declared i.e there is transitive dependency for these projects. But the module does not require them, so we need to declare them as permitUnusedDeclared .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...he\_beam/transforms/combinefn\_lifecycle\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lZm5fbGlmZWN5Y2xlX3BpcGVsaW5lLnB5) | | |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | | |
| [sdks/python/apache\_beam/io/gcp/spanner.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3NwYW5uZXIucHk=) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...5068d90](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (8b45b0f) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47587 +3
+ Misses 9934 9931 -3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.57% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.28% <0.00%> (+0.35%)` | :arrow_up: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...b8f78ed](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d6cc0ed9ed537229b27b5dbe73288f21b0e351c?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.02%
==========================================
Files 455 453 -2
Lines 54876 54610 -266
==========================================
- Hits 45266 45058 -208
+ Misses 9610 9552 -58
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `83.33% <0.00%> (-9.53%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/tests/bigquery\_matcher.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXIucHk=) | `79.83% <0.00%> (-2.87%)` | :arrow_down: |
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/retry.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcmV0cnkucHk=) | `86.27% <0.00%> (-0.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `90.77% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/metrics/metricbase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWNiYXNlLnB5) | `87.87% <0.00%> (-0.36%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.45% <0.00%> (-0.36%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `83.75% <0.00%> (-0.29%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `77.77% <0.00%> (-0.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [c0a7e66...4c5041c](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d52d009) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.78%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.58% +47.78%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47491 +28347
+ Misses 35864 10012 -25852
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.07% <ø> (+42.93%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d52d009](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550450329
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
`:runners:flink:1.10:job-server:analyzeClassesDependencies `task fails if we don't add `permitUnusedDeclared project(":runners:flink:1.10")`
```
Task :runners:flink:1.10:job-server:analyzeClassesDependencies FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':runners:flink:1.10:job-server:analyzeClassesDependencies'.
> Dependency analysis found issues.
unusedDeclaredArtifacts:
- beam.runners.flink:1.10:2.28.0-SNAPSHOT@jar
```
As it is transitively being declared, but we do not need it here. Thats why it is important to declare it permitUnsedDeclared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (d5e63af) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.70% +47.90%
===========================================
Files 437 466 +29
Lines 55008 57518 +2510
===========================================
+ Hits 19144 47572 +28428
+ Misses 35864 9946 -25918
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/portability/common\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvY29tbW9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...pache\_beam/portability/api/beam\_fn\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZm5fYXBpX3BiMl9ncnBjLnB5) | `72.64% <0.00%> (ø)` | |
| [...he\_beam/portability/api/standard\_window\_fns\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyLnB5) | `100.00% <0.00%> (ø)` | |
| [...m/portability/api/beam\_interactive\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1faW50ZXJhY3RpdmVfYXBpX3BiMl9ncnBjLnB5) | `0.00% <0.00%> (ø)` | |
| [...on/apache\_beam/portability/api/beam\_job\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/standard\_window\_fns\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL3N0YW5kYXJkX3dpbmRvd19mbnNfcGIyX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...am/portability/api/external\_transforms\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyX2dycGMucHk=) | `0.00% <0.00%> (ø)` | |
| [.../apache\_beam/portability/api/endpoints\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjJfZ3JwYy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...che\_beam/portability/api/beam\_expansion\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fZXhwYW5zaW9uX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...d5e63af](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (ab8fb61) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 466 466
Lines 57514 57514
==========================================
- Hits 47584 47582 -2
- Misses 9930 9932 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...ab8fb61](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (766e0eb) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc) (7ef8bd1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 466 466
Lines 57514 57518 +4
==========================================
- Hits 47584 47583 -1
- Misses 9930 9935 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `91.66% <0.00%> (-0.76%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.18%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [7ef8bd1...766e0eb](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (b1cb732) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.80%`.
> The diff coverage is `86.84%`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.60% +47.80%
===========================================
Files 437 466 +29
Lines 55008 57503 +2495
===========================================
+ Hits 19144 47499 +28355
+ Misses 35864 10004 -25860
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <ø> (+42.67%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+31.31%)` | :arrow_up: |
| [...thon/apache\_beam/runners/portability/job\_server.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9qb2Jfc2VydmVyLnB5) | `51.06% <0.00%> (+51.06%)` | :arrow_up: |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `31.41% <0.00%> (+0.20%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.81% <28.57%> (+35.94%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `75.27% <50.00%> (+48.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `85.97% <88.88%> (+20.69%)` | :arrow_up: |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.36% <92.30%> (+72.50%)` | :arrow_up: |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | `93.54% <93.54%> (ø)` | |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.65% <96.96%> (+47.10%)` | :arrow_up: |
| ... and [355 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...b1cb732](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (e3d2be0) into [master](https://codecov.io/gh/apache/beam/commit/8ab1955550931fad398048a5990ebea868406587?el=desc) (8ab1955) will **increase** coverage by `47.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
===========================================
+ Coverage 34.80% 82.50% +47.70%
===========================================
Files 437 453 +16
Lines 55008 54610 -398
===========================================
+ Hits 19144 45058 +25914
+ Misses 35864 9552 -26312
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [conftest.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/urns.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdXJucy5weQ==) | `88.88% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/runners/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [.../internal/clients/bigquery/bigquery\_v2\_messages.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvYmlncXVlcnlfdjJfbWVzc2FnZXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...\_beam/runners/interactive/user\_pipeline\_tracker.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91c2VyX3BpcGVsaW5lX3RyYWNrZXIucHk=) | | |
| [sdks/python/apache\_beam/utils/sentinel.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2VudGluZWwucHk=) | | |
| [...he\_beam/transforms/combinefn\_lifecycle\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lZm5fbGlmZWN5Y2xlX3BpcGVsaW5lLnB5) | | |
| ... and [348 more](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [d009fe9...7d388fa](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256
# [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
> Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc) (8b45b0f) into [master](https://codecov.io/gh/apache/beam/commit/5c755eafe2338ae958585c209acfb9bc571aa21d?el=desc) (5c755ea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12938 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 466 466
Lines 57518 57518
=======================================
+ Hits 47584 47587 +3
+ Misses 9934 9931 -3
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.57% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3FsX3RheGkucHk=) | `0.00% <0.00%> (ø)` | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.28% <0.00%> (+0.35%)` | :arrow_up: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.82% <0.00%> (+0.52%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.24% <0.00%> (+1.75%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer). Last update [5c755ea...8b45b0f](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530168459
##########
File path: runners/flink/1.11/build.gradle
##########
@@ -31,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_clients_version"
Review comment:
@kennknowles, using wfhartford plugin(https://github.com/wfhartford/gradle-dependency-analyze#configurations) for dependency check by running "gradle analyzeDependencies --scan" gives result of of the unusedDeclared and usedUndeclared dependency list. The plugin says flink client is UnusedDeclared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-733607715
For context on why the changes are necessary, it would help to add a description to this PR and include any design docs.
JIRA: https://issues.apache.org/jira/browse/BEAM-10961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550847270
##########
File path: runners/flink/1.9/build.gradle
##########
@@ -17,6 +17,7 @@
*/
def basePath = '..'
+
Review comment:
stray change please revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #12938: BEAM-10961- Enable strict dependency analysis on all Java modules
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r535252493
##########
File path: runners/flink/1.8/job-server/build.gradle
##########
@@ -29,3 +29,8 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.8")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Done as per your recommendation :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org