You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org> on 2010/01/26 12:36:34 UTC
[jira] Created: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
----------------------------------------------------------------------------------------------
Key: QPID-2360
URL: https://issues.apache.org/jira/browse/QPID-2360
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.6
Reporter: Robbie Gemmell
Fix For: 0.7
Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch
Removed unused tests
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851397#action_12851397 ]
Robbie Gemmell commented on QPID-2360:
--------------------------------------
Patches commited
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-broker-src.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-branch.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-systests-etc.patch
qpid-2360-systests-src.patch
Patches for system tests affected by virtualhosts configuration changes.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-systests-src.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-systests-src.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch
Updated patches for branch and trunk, with changes as suggested.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-trunk-all.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847436#action_12847436 ]
Robbie Gemmell commented on QPID-2360:
--------------------------------------
The trunk patch does not compile because it also contains various other (unfinished?) changes to classes unrelated to the update of the
server/virtualhost configuration and their tests, eg: reorganised imports, addition of generic types, spacing, annotations etc. MockAMQQueue changes also add a tab character that should be removed. It would be best to split these types of change and any others which aren't related to the configuration updates out into a new JIRA and patch, as it will make both a lot easier to digest.
The changes to ServeConfiguration itself in order to address the issues raised look good, however there are some points to address with the changes:
ServerConfigurationTest: L904 is now a function definition that does nothing other than call itself, and so gets stuck in an infinite recursion when used by the Firewall related test methods, leading to a StackOverFlowException when they are run.
ServerConfiguration: L165 The exception should be updated to say "Only one external virtualhosts configuration *file* allowed, *multiple filenames found*" to avoid users thinking they have too many virtualhosts should the exception ever be thrown, rather than that they have just specified multiple strings that we then assume to be file locations.
ServerConfiguration: L192 This comment has been made invalid by the patch changes and should be removed: "// Add the keys of the virtual host to the main config"
I think that the broker/etc/log4j.xml configuration should not be modified to suppress warnings regarding optional config files not being present, with the associated logging level left as-is. Primarily only the tests use the ConfigurationFactory abilities and then the optional ability on top of that, so this will rarely if ever be logged in actual use, but it should be output when it is.
broker/etc/transient_config.xml and broker/etc/persistent_config.xml should just be removed (they are not really used at all, at worst some tests use them and if so they should just be updated to use overrides where required.) rather than updating them and adding new individualised virtualhosts files for each and causing more clutter in the repository and Apache release bundles.
Related to the above, the new virtualhost files referenced in the patch changes are not actually included in the patch and so are missing. Similarly for the main new broker/etc/virtualhosts.xml file and various new virtualhosts files for the Systests module.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch, qpid-2360-trunk-all.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-broker-src.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch, qpid-2360-trunk-all.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850870#action_12850870 ]
Robbie Gemmell commented on QPID-2360:
--------------------------------------
The configuration changes dont fully account for the Security configuration, particularly the ability to reload the security configuration at runtime (eg to update the Firewall configuration). ServerConfiguration.reparseConfigFIleSecuritySections() expects the virtualhost configuration properties to be part of the main configuration, which is not the case now when an external virtualhosts configuration file is used.
As such this needs updated to determine whether an external file was used to configure the virtualhost such that the configuration sections are properly reparsed. This is not detected by the firewall related unit/system tests in ServerConfiguration and FirewallConfigTest, as some utilise only broker level security configuration, and the others utilise virtualhost level configuration but when the main config is reparsed and the virtualhosts file isnt, it will return an empty subset of virtualhost security and the firewall will then deny by default, which is what the tests expect to occur and so no problem is found.
The updated (trunk) patch contains a number of .orig files, presumably from 'unclean' patch runs. It also still contains some seemingly unrelated modifications (eg in AlertingTest, which now fails when run). If these are unrelated but still required changes, a new JIRA should be raised for them to allow proper tracking of the issue.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-branch.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-broker-src.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch
Updated patches
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845959#action_12845959 ]
Andrew Kennedy commented on QPID-2360:
--------------------------------------
Patch also fixes QPID-2360 issue.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2361.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-broker-etc.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch, qpid-2360-trunk-all.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2361.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-broker-src.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2361.patch
Patch for ServerConfiguration.java and ServerConfigurationTest.java that separates virtualhosts configuration mechanisms.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2361.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851798#action_12851798 ]
Robbie Gemmell commented on QPID-2360:
--------------------------------------
Patches were commited in revisions 929136 and 929138. The commit log statement was incorrect at the time, but has since been updated with the correct issue numbers.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-broker-src.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-broker-etc.patch
qpid-2360-broker-src.patch
Patch fixes QPID-2360 and QPID-2361 by changing virtualhost s configuration mechanisms to be mutually exclusive. Patch includes changes to config files.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-2360:
------------------------------------
Assignee: Robbie Gemmell
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch, qpid-2360-trunk-all.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-branch.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-systests-src.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-broker-src.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-systests-etc.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: qpid-2360-systests-src.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Issue Comment Edited: (QPID-2360) declaring virtualhost
level firewall configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845959#action_12845959 ]
Andrew Kennedy edited comment on QPID-2360 at 3/16/10 4:03 PM:
---------------------------------------------------------------
Patch also fixes QPID-2361 issue.
was (Author: andrew.kennedy):
Patch also fixes QPID-2360 issue.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2361.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-2360:
---------------------------------
Status: Ready To Review (was: In Progress)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-trunk-all.patch
Patch for trunk, all files together, because 0.5 branch patches do not apply correctly.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch, qpid-2360-trunk-all.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-broker-src.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: qpid-2360-systests-src.patch
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: qpid-2360-broker-etc.patch, qpid-2360-broker-src.patch, qpid-2360-systests-etc.patch, qpid-2360-systests-src.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2360) declaring virtualhost level firewall
configuration in virtualhosts.xml leads to NPE on startup
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2360:
---------------------------------
Attachment: (was: 0001-QPID-2630-QPID-2631-branch.patch)
> declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org