You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2006/11/25 02:56:01 UTC
[jira] Created: (OFBIZ-495) User Preferences Feature
User Preferences Feature
------------------------
Key: OFBIZ-495
URL: http://issues.apache.org/jira/browse/OFBIZ-495
Project: OFBiz (The Open for Business Project)
Issue Type: New Feature
Reporter: Adrian Crum
Priority: Minor
The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
That attached patch should be applied to the framework folder of revision 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to https://127.0.0.1:8443/example/control/UserPrefDemo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-495) User Preferences Feature
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-495?page=comments#action_12452564 ]
David E. Jones commented on OFBIZ-495:
--------------------------------------
Just a few quick thoughts based on an initial review of this:
1. there are dozens of lines unnecessarily changed in this patch (ie formatting changes, etc that have nothing to do with functionality)
2. a few Java formatting faux pas, like if/else without curly braces
3. this should go into an existing component instead of being added to a new component; perhaps the "common" component would be a good fit, but this should probably be discussed (along with various other things)
4. why were the services written in Java and not as simple-methods? these seem to mostly be getting and organizing data into generic structures, which is what simple-methods are best for
5. this patch somehow has two copies of each file/change...
In general because this is a fair sized change this should be evaluated and feedback offered by various people. Review of this sort of thing should include review of entity model additions, security/permissions, seed and demo data (and properly split into seed and demo files), implementation approaches, general organization, examples, etc.
More generally, this looks like a great start Adrian, so I hope it picks up interest and is finished and included in OFBiz.
> User Preferences Feature
> ------------------------
>
> Key: OFBIZ-495
> URL: http://issues.apache.org/jira/browse/OFBIZ-495
> Project: OFBiz (The Open for Business Project)
> Issue Type: New Feature
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: framework.patch
>
>
> The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
> That attached patch should be applied to the framework folder of revision 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to https://127.0.0.1:8443/example/control/UserPrefDemo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-495) User Preferences Feature
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-495?page=comments#action_12452603 ]
Adrian Crum commented on OFBIZ-495:
-----------------------------------
David,
Thank you very much for reviewing this! I'll adress the formatting/patch issues after it has been discussed - I figured I will be rewriting sections after it has been evaluated. I wanted to get it out there ASAP so people could comment on it, and for some reason my SVN client started acting flakey.
I don't know about the dozens of lines thing. Most of it I wrote from scratch. The only existing file that was modified (outside the example component) was UtilMisc. As far as I know I didn't reformat that. I'll take a look at it though.
The Java classes were used so they can be subclassed or wrapped with other Java classes. I was trying to make it as flexible/extensible as possible.
By the way, for anyone reviewing this - the example component is just being used to demonstrate the feature. That part of the patch is not intended to be made part of the project.
Thanks again for taking a look at this. I'll address your suggestions once everyone has commented.
> User Preferences Feature
> ------------------------
>
> Key: OFBIZ-495
> URL: http://issues.apache.org/jira/browse/OFBIZ-495
> Project: OFBiz (The Open for Business Project)
> Issue Type: New Feature
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: framework.patch
>
>
> The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
> That attached patch should be applied to the framework folder of revision 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to https://127.0.0.1:8443/example/control/UserPrefDemo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-495) User Preferences Feature
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-495?page=all ]
Adrian Crum updated OFBIZ-495:
------------------------------
Attachment: example.patch
Uploaded example.patch:
This patch contains the User Preference demo screen that was in the original framework.patch file. It is NOT intended to be committed to the project - it is for demonstration purposes only.
Apply the patch to the framework/example folder. Start OFBiz and import the framework/example/data/UserPrefData.xml file using Webtools. Browse to
https://127.0.0.1:8443/example/control/UserPrefDemo
to view the demo page.
> User Preferences Feature
> ------------------------
>
> Key: OFBIZ-495
> URL: http://issues.apache.org/jira/browse/OFBIZ-495
> Project: OFBiz (The Open for Business Project)
> Issue Type: New Feature
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: example.patch, framework.patch, framework_v2.patch
>
>
> The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
> That attached patch should be applied to the framework folder of revision 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to https://127.0.0.1:8443/example/control/UserPrefDemo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-495) User Preferences Feature
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-495?page=all ]
Adrian Crum updated OFBIZ-495:
------------------------------
Attachment: framework_v2.patch
Uploaded framework_v2.patch:
The User Preferences feature has been updated to include David's suggestions.
1.The "Java formatting faux pas" were in the original UtilMisc.java file, which I copy/pasted one method in. I reformatted the entire file to get it to comply with current OFBiz coding standards. At the very least, this file should be committed.
2. The User Preference feature has been moved to the common component.
3. I fixed the problems with my SVN client which cause duplicate files in the original patch.
4. I eliminated the example component demo code and data.
I applied the patch to the framework folder of the most recent SVN version and it works.
I'm done with this issue. If anyone else wants to develop it further, they are welcome to do so.
> User Preferences Feature
> ------------------------
>
> Key: OFBIZ-495
> URL: http://issues.apache.org/jira/browse/OFBIZ-495
> Project: OFBiz (The Open for Business Project)
> Issue Type: New Feature
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: framework.patch, framework_v2.patch
>
>
> The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
> That attached patch should be applied to the framework folder of revision 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to https://127.0.0.1:8443/example/control/UserPrefDemo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-495) User Preferences Feature
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-495?page=all ]
Adrian Crum updated OFBIZ-495:
------------------------------
Attachment: framework.patch
The patch.
> User Preferences Feature
> ------------------------
>
> Key: OFBIZ-495
> URL: http://issues.apache.org/jira/browse/OFBIZ-495
> Project: OFBiz (The Open for Business Project)
> Issue Type: New Feature
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: framework.patch
>
>
> The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
> That attached patch should be applied to the framework folder of revision 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to https://127.0.0.1:8443/example/control/UserPrefDemo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira