You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Dave Brosius <db...@mebigfatguy.com> on 2013/05/20 21:50:11 UTC

Review Request: remove bogus self assign to parent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11247/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

code assigns 

this.parent = parent; 

even tho there isn't any non-field parent in the constructor... 
removed.


Diffs
-----

  core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java d928e0c 

Diff: https://reviews.apache.org/r/11247/diff/


Testing
-------


Thanks,

Dave Brosius

Re: Review Request: remove bogus self assign to parent

Posted by Nitin Mehta <ni...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11247/#review20826
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On May 20, 2013, 7:50 p.m., Dave Brosius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11247/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 7:50 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> code assigns 
> 
> this.parent = parent; 
> 
> even tho there isn't any non-field parent in the constructor... 
> removed.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java d928e0c 
> 
> Diff: https://reviews.apache.org/r/11247/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>