You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by am...@apache.org on 2018/08/15 19:56:01 UTC

asterixdb git commit: [NO ISSUE][TXN] Fix extension datasets tuple translators

Repository: asterixdb
Updated Branches:
  refs/heads/master 4af131ada -> 51aef3c22


[NO ISSUE][TXN] Fix extension datasets tuple translators

Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2908
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <ba...@gmail.com>
Reviewed-by: Murtadha Hubail <mh...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/51aef3c2
Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/51aef3c2
Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/51aef3c2

Branch: refs/heads/master
Commit: 51aef3c2283cee81ae4e57295bddb7abf555cb0c
Parents: 4af131a
Author: Abdullah Alamoudi <ba...@gmail.com>
Authored: Wed Aug 15 08:28:26 2018 -0700
Committer: abdullah alamoudi <ba...@gmail.com>
Committed: Wed Aug 15 12:55:32 2018 -0700

----------------------------------------------------------------------
 .../metadata/api/ExtensionMetadataDataset.java  |  8 +++---
 .../IMetadataEntityTupleTranslatorFactory.java  | 29 ++++++++++++++++++++
 2 files changed, 33 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/asterixdb/blob/51aef3c2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
index d25f488..ebb9cac 100644
--- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
@@ -29,16 +29,16 @@ public class ExtensionMetadataDataset<T> extends MetadataIndex {
 
     private static final long serialVersionUID = 1L;
     private final ExtensionMetadataDatasetId indexId;
-    private final transient IMetadataEntityTupleTranslator<T> tupleTranslator;
+    private final transient IMetadataEntityTupleTranslatorFactory<T> tupleTranslatorFactory;
 
     public ExtensionMetadataDataset(MetadataIndexImmutableProperties indexProperties, int numFields, IAType[] keyTypes,
             List<List<String>> keyNames, int numSecondaryIndexKeys, ARecordType payloadType, boolean isPrimaryIndex,
             int[] primaryKeyIndexes, ExtensionMetadataDatasetId indexId,
-            IMetadataEntityTupleTranslator<T> tupleTranslator) {
+            IMetadataEntityTupleTranslatorFactory<T> tupleTranslatorFactory) {
         super(indexProperties, numFields, keyTypes, keyNames, numSecondaryIndexKeys, payloadType, isPrimaryIndex,
                 primaryKeyIndexes);
         this.indexId = indexId;
-        this.tupleTranslator = tupleTranslator;
+        this.tupleTranslatorFactory = tupleTranslatorFactory;
     }
 
     public ExtensionMetadataDatasetId getId() {
@@ -46,6 +46,6 @@ public class ExtensionMetadataDataset<T> extends MetadataIndex {
     }
 
     public IMetadataEntityTupleTranslator<T> getTupleTranslator() {
-        return tupleTranslator;
+        return tupleTranslatorFactory.createTupleTranslator();
     }
 }

http://git-wip-us.apache.org/repos/asf/asterixdb/blob/51aef3c2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
new file mode 100644
index 0000000..e472383
--- /dev/null
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.metadata.api;
+
+import java.io.Serializable;
+
+public interface IMetadataEntityTupleTranslatorFactory<T> extends Serializable {
+
+    /**
+     * @return an instance of IMetadataEntityTupleTranslator
+     */
+    IMetadataEntityTupleTranslator<T> createTupleTranslator();
+}