You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2009/08/26 20:21:59 UTC

[jira] Created: (HBASE-1798) [Regression] Deletes not working as they were

[Regression] Deletes not working as they were
---------------------------------------------

                 Key: HBASE-1798
                 URL: https://issues.apache.org/jira/browse/HBASE-1798
             Project: Hadoop HBase
          Issue Type: Bug
    Affects Versions: 0.20.0
            Reporter: Jean-Daniel Cryans
         Attachments: HBASE-1798.patch

2 problems:

 - You can't delete in the future.
 - You can't put, delete family, put again the same row. It was working in 0.19 but now it is broken (unless you force a major compaction). Deleting just a column works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1798) [Regression] Unable to delete a row in the future

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-1798:
--------------------------------------

    Description: Deleting in the future doesn't work because KV resets everything to now.  (was: 2 problems:

 - You can't delete in the future.
 - You can't put, delete family, put again the same row. It was working in 0.19 but now it is broken (unless you force a major compaction). Deleting just a column works.)
       Assignee: Jean-Daniel Cryans
        Summary: [Regression] Unable to delete a row in the future  (was: [Regression] Deletes not working as they were)

Changing the description of the issue, it's only about deleting in the future.

> [Regression] Unable to delete a row in the future
> -------------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>         Attachments: HBASE-1798-ryan.patch, HBASE-1798-v1.patch, HBASE-1798.patch
>
>
> Deleting in the future doesn't work because KV resets everything to now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1798) [Regression] Deletes not working as they were

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-1798:
--------------------------------------

    Attachment: HBASE-1798.patch

This patch solves the first problem and demonstrates the second.

> [Regression] Deletes not working as they were
> ---------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>         Attachments: HBASE-1798.patch
>
>
> 2 problems:
>  - You can't delete in the future.
>  - You can't put, delete family, put again the same row. It was working in 0.19 but now it is broken (unless you force a major compaction). Deleting just a column works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1798) [Regression] Unable to delete a row in the future

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans resolved HBASE-1798.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
                   0.20.0
     Hadoop Flags: [Reviewed]

Committed to branch and trunk.

> [Regression] Unable to delete a row in the future
> -------------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.0, 0.21.0
>
>         Attachments: HBASE-1798-2.patch, HBASE-1798-3.patch, HBASE-1798-ryan.patch, HBASE-1798-v1.patch, HBASE-1798.patch
>
>
> Deleting in the future doesn't work because KV resets everything to now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1798) [Regression] Deletes not working as they were

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1798:
---------------------------------

    Attachment: HBASE-1798-v1.patch

Unit test passes.  Shows the behavior.

If you delete at a timestamp, new puts to that same timestamp do not show up.

> [Regression] Deletes not working as they were
> ---------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>         Attachments: HBASE-1798-v1.patch, HBASE-1798.patch
>
>
> 2 problems:
>  - You can't delete in the future.
>  - You can't put, delete family, put again the same row. It was working in 0.19 but now it is broken (unless you force a major compaction). Deleting just a column works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1798) [Regression] Unable to delete a row in the future

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748193#action_12748193 ] 

ryan rawson commented on HBASE-1798:
------------------------------------

looking good JD, this is a patch i can heartily approve.

+1

> [Regression] Unable to delete a row in the future
> -------------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>         Attachments: HBASE-1798-2.patch, HBASE-1798-ryan.patch, HBASE-1798-v1.patch, HBASE-1798.patch
>
>
> Deleting in the future doesn't work because KV resets everything to now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1798) [Regression] Deletes not working as they were

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1798:
-------------------------------

    Attachment: HBASE-1798-ryan.patch

this pair of modified tests pass.

> [Regression] Deletes not working as they were
> ---------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>         Attachments: HBASE-1798-ryan.patch, HBASE-1798-v1.patch, HBASE-1798.patch
>
>
> 2 problems:
>  - You can't delete in the future.
>  - You can't put, delete family, put again the same row. It was working in 0.19 but now it is broken (unless you force a major compaction). Deleting just a column works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1798) [Regression] Unable to delete a row in the future

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-1798:
--------------------------------------

    Attachment: HBASE-1798-2.patch

This patch does 2 things:

 - First it changes KV to only reset to now if LATEST_TIMESTAMP.
 - In HRegion, if you delete a row without specifying families, it was eating the timestamp you may have set.

> [Regression] Unable to delete a row in the future
> -------------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>         Attachments: HBASE-1798-2.patch, HBASE-1798-ryan.patch, HBASE-1798-v1.patch, HBASE-1798.patch
>
>
> Deleting in the future doesn't work because KV resets everything to now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1798) [Regression] Unable to delete a row in the future

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-1798:
--------------------------------------

    Attachment: HBASE-1798-3.patch

I will commit this patch with a new test for HRegion.

> [Regression] Unable to delete a row in the future
> -------------------------------------------------
>
>                 Key: HBASE-1798
>                 URL: https://issues.apache.org/jira/browse/HBASE-1798
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>         Attachments: HBASE-1798-2.patch, HBASE-1798-3.patch, HBASE-1798-ryan.patch, HBASE-1798-v1.patch, HBASE-1798.patch
>
>
> Deleting in the future doesn't work because KV resets everything to now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.