You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/30 11:37:55 UTC

[GitHub] [incubator-devlake] mappjzc commented on a diff in pull request #2394: fix: convert story point to signed integer

mappjzc commented on code in PR #2394:
URL: https://github.com/apache/incubator-devlake/pull/2394#discussion_r910858388


##########
models/domainlayer/ticket/issue.go:
##########
@@ -34,7 +34,7 @@ type Issue struct {
 	Type                    string `gorm:"type:varchar(100)"`
 	Status                  string `gorm:"type:varchar(100)"`
 	OriginalStatus          string `gorm:"type:varchar(100)"`
-	StoryPoint              uint
+	StoryPoint              int64

Review Comment:
   18446744073709551615 is 2^64 -1 ,but int64 is -2^63 to 2^63.
   Is int64 enough?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org