You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/04 10:26:14 UTC

[GitHub] [flink] XComp opened a new pull request #14549: [FLINK-20841][build][avro/parquet] Removed packages with auto-generated sources from .gitignore.

XComp opened a new pull request #14549:
URL: https://github.com/apache/flink/pull/14549


   ## What is the purpose of the change
   
   We ran into compilation failures because of duplicated classes in the classpath after changes were introduced by [FLINK-20790](https://issues.apache.org/jira/browse/FLINK-20790). The packages containing generated source still appeared in .gitignore which caused those packages to not being deleted.
   
   
   ## Brief change log
   
   * `.gitignore` got cleaned up.
   
   ## Verifying this change
   
   `mvn test-compile` was executed on all three packages with the generated-sources packages being removed.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14549: [FLINK-20841][build][avro/parquet] Removed packages with auto-generated sources from .gitignore.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14549:
URL: https://github.com/apache/flink/pull/14549#issuecomment-753893642


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4331ce68fd4a4baf0e5573dbb66e79b0da664cba (Mon Jan 04 10:28:46 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14549: [FLINK-20841][build][avro/parquet] Removed packages with auto-generated sources from .gitignore.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14549:
URL: https://github.com/apache/flink/pull/14549#issuecomment-753893642


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4331ce68fd4a4baf0e5573dbb66e79b0da664cba (Fri May 28 06:59:54 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14549: [FLINK-20841][build][avro/parquet] Removed packages with auto-generated sources from .gitignore.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14549:
URL: https://github.com/apache/flink/pull/14549#issuecomment-753901587


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4331ce68fd4a4baf0e5573dbb66e79b0da664cba",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11602",
       "triggerID" : "4331ce68fd4a4baf0e5573dbb66e79b0da664cba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4331ce68fd4a4baf0e5573dbb66e79b0da664cba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11602) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #14549: [FLINK-20841][build][avro/parquet] Removed packages with auto-generated sources from .gitignore.

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14549:
URL: https://github.com/apache/flink/pull/14549#issuecomment-753943605


   Eh let's merge it right away so people on master don't run into issues after a rebase...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #14549: [FLINK-20841][build][avro/parquet] Removed packages with auto-generated sources from .gitignore.

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14549:
URL: https://github.com/apache/flink/pull/14549


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14549: [FLINK-20841][build][avro/parquet] Removed packages with auto-generated sources from .gitignore.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14549:
URL: https://github.com/apache/flink/pull/14549#issuecomment-753901587


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4331ce68fd4a4baf0e5573dbb66e79b0da664cba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4331ce68fd4a4baf0e5573dbb66e79b0da664cba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4331ce68fd4a4baf0e5573dbb66e79b0da664cba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org