[GitHub] [solr] gerlowskija commented on a diff in pull request #1210: SOLR-16347: Skip JerseyApp creation when v2 disabled

[GitBox <gi...@apache.org>]

gerlowskija commented on code in PR #1210:
URL: https://github.com/apache/solr/pull/1210#discussion_r1038473291


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -297,6 +297,9 @@ && getZkController().getOverseer() != null
   public static final long INITIAL_CORE_LOAD_COMPLETE = 0x4L;
   private volatile long status = 0L;
 
+  public static final boolean IS_V2_ENABLED =
+      !"true".equals(System.getProperty("disable.v2.api", "false"));

Review Comment:
   Idk - I'm sure there's a handful of ways to do it.  Probably the cleanest way would be to put a static utility method in V2ApiUtils that abstracts the actual mechanism away entirely.
   
   Tbh I just copied this line from an existing place that we lookup this sysprop - it is a draft PR after all 😛. I'll clean up the actual lookup a bit as I get this ready to merge.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org