You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/20 12:09:33 UTC
[GitHub] [commons-lang] rednikeeg opened a new pull request, #936: LANG-1604: Deprecate RandomUtils class
rednikeeg opened a new pull request, #936:
URL: https://github.com/apache/commons-lang/pull/936
jira issue - https://issues.apache.org/jira/browse/LANG-1604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #936: LANG-1604: Deprecate RandomUtils class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #936:
URL: https://github.com/apache/commons-lang/pull/936#issuecomment-1221537211
When you want to deprecate a class or a method you should explain and point to exactly what the desired replacement is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] rednikeeg commented on a diff in pull request #936: LANG-1604: Deprecate RandomUtils class
Posted by GitBox <gi...@apache.org>.
rednikeeg commented on code in PR #936:
URL: https://github.com/apache/commons-lang/pull/936#discussion_r951795022
##########
src/main/java/org/apache/commons/lang3/RandomUtils.java:
##########
@@ -30,8 +30,10 @@
* a better choice for applications with more stringent requirements
* (performance and/or correctness).</p>
*
+ * @deprecated for more optimized implementation from commons-rng
Review Comment:
Added reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] rednikeeg commented on a diff in pull request #936: LANG-1604: Deprecate RandomUtils class
Posted by GitBox <gi...@apache.org>.
rednikeeg commented on code in PR #936:
URL: https://github.com/apache/commons-lang/pull/936#discussion_r950836049
##########
src/main/java/org/apache/commons/lang3/RandomUtils.java:
##########
@@ -30,8 +30,10 @@
* a better choice for applications with more stringent requirements
* (performance and/or correctness).</p>
*
+ * @deprecated for more optimized implementation from commons-rng
Review Comment:
Sorry, I didn't understand. What should I do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #936: LANG-1604: Deprecate RandomUtils class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #936:
URL: https://github.com/apache/commons-lang/pull/936#discussion_r950694283
##########
src/main/java/org/apache/commons/lang3/RandomUtils.java:
##########
@@ -30,8 +30,10 @@
* a better choice for applications with more stringent requirements
* (performance and/or correctness).</p>
*
+ * @deprecated for more optimized implementation from commons-rng
Review Comment:
Please add a URL to the Javadoc for the favored implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] rednikeeg closed pull request #936: LANG-1604: Deprecate RandomUtils class
Posted by GitBox <gi...@apache.org>.
rednikeeg closed pull request #936: LANG-1604: Deprecate RandomUtils class
URL: https://github.com/apache/commons-lang/pull/936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] rednikeeg commented on a diff in pull request #936: LANG-1604: Deprecate RandomUtils class
Posted by GitBox <gi...@apache.org>.
rednikeeg commented on code in PR #936:
URL: https://github.com/apache/commons-lang/pull/936#discussion_r950836049
##########
src/main/java/org/apache/commons/lang3/RandomUtils.java:
##########
@@ -30,8 +30,10 @@
* a better choice for applications with more stringent requirements
* (performance and/or correctness).</p>
*
+ * @deprecated for more optimized implementation from commons-rng
Review Comment:
Sorry, I don't understand. What should I do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #936: LANG-1604: Deprecate RandomUtils class
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #936:
URL: https://github.com/apache/commons-lang/pull/936#issuecomment-1221310214
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/936?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#936](https://codecov.io/gh/apache/commons-lang/pull/936?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3daf5df) into [master](https://codecov.io/gh/apache/commons-lang/commit/ceb7fbb0336f21f74d2b096cc0b418d62a1a3fe1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ceb7fbb) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #936 +/- ##
============================================
- Coverage 92.01% 92.01% -0.01%
+ Complexity 7436 7435 -1
============================================
Files 189 189
Lines 15751 15751
Branches 2961 2961
============================================
- Hits 14494 14493 -1
Misses 672 672
- Partials 585 586 +1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ain/java/org/apache/commons/lang3/RandomUtils.java](https://codecov.io/gh/apache/commons-lang/pull/936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvUmFuZG9tVXRpbHMuamF2YQ==) | `97.22% <ø> (ø)` | |
| [...apache/commons/lang3/reflect/ConstructorUtils.java](https://codecov.io/gh/apache/commons-lang/pull/936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvcmVmbGVjdC9Db25zdHJ1Y3RvclV0aWxzLmphdmE=) | `84.00% <0.00%> (-2.00%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org