You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/22 10:55:17 UTC

[GitHub] [beam] alexvanboxel commented on a change in pull request #11074: Store logical type values in Row instead of base values

alexvanboxel commented on a change in pull request #11074: Store logical type values in Row instead of base values
URL: https://github.com/apache/beam/pull/11074#discussion_r396074521
 
 

 ##########
 File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java
 ##########
 @@ -396,8 +396,8 @@ public void testLogicalTypes() {
 
     PCollection<Row> outputRow =
         pipeline
-            .apply(Create.of(row))
-            .setRowSchema(outputRowSchema)
+            .apply(Create.of(row).withRowSchema(inputRowSchema))
+            //  .setRowSchema(outputRowSchema)
 
 Review comment:
   Remove comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services