You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Nicolas Lalevée (JIRA)" <ji...@apache.org> on 2013/03/31 17:45:15 UTC
[jira] [Resolved] (IVYDE-329) Disable DTD external fetching for
matching ivy/ivy
[ https://issues.apache.org/jira/browse/IVYDE-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée resolved IVYDE-329.
-----------------------------------
Resolution: Fixed
Fix Version/s: trunk
Assignee: Nicolas Lalevée
Last patches applied on trunk of Ivy and IvyDE.
I just had to make a clone of XMLParser so that IvyDE doesn't require the lastest version of Ivy.
Thank you very much for your contribution.
> Disable DTD external fetching for matching ivy/ivy
> --------------------------------------------------
>
> Key: IVYDE-329
> URL: https://issues.apache.org/jira/browse/IVYDE-329
> Project: IvyDE
> Issue Type: Improvement
> Environment: Ivy 2.4.0.alpha/IvyDE 2.2.0.beta2
> Reporter: Stephen Haberman
> Assignee: Nicolas Lalevée
> Labels: patch
> Fix For: trunk
>
> Attachments: ivyde-xml-dtd-hung.txt, optionalExternalDtds.diff, optionalExternalDtds-ivyde.diff
>
>
> Our team uses Ivy/IvyDE, and noticed Eclipse hanging today/yesterday, to the point of being unusable.
> I tracked it down to Eclipse asking IvyDE "is this your file?", which IvyDE's IvySettingsContentDescriber used XMLHelper.parse to answer, but then Xerces hung while trying to load the XML file's DTD.
> So, the problem was the DTD being unavailable, but it seems like XMLHelper should turn this off, especially if the schema parameter is null, and it's in non-validating mode.
> The attached patch turns off external DTD fetching when XMLHelper is already in non-validating mode.
> This avoids the wire call, which speeds up the XMLHelper.parse by at least 100%, ~250-300ms when fetching the DTD, to ~100-150ms when not. (And this is the happy case, in the worst case, waiting for the timeout if the DTD is unavailable, takes ~20s).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira