You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/11/11 00:14:45 UTC

Review Request 27841: Ambari DB DDL create script doesn't properly create table cluster_version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27841/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, John Speidel, and Sid Wagle.


Bugs: AMBARI-8264
    https://issues.apache.org/jira/browse/AMBARI-8264


Repository: ambari


Description
-------

The embedded DB creation sctipt: src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql incorrectly creates the cluster_version table in the wrong schema.
CREATE TABLE cluster_version (...)
It should be:
CREATE TABLE ambari.cluster_version (...)
This will cause a failure when creating a cluster stating that the relation cluster_version doesn't exist.


Diffs
-----

  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a8b92e7 

Diff: https://reviews.apache.org/r/27841/diff/


Testing
-------

Copied the change sql file to a host after running yum install ambari-server -y and before ambari-server setup -s.
Then verified that the table was created correctly,
psql -U ambari -d ambari
\d
\d cluster_version
\d host_version


Thanks,

Alejandro Fernandez


Re: Review Request 27841: Ambari DB DDL create script doesn't properly create table cluster_version

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27841/#review60707
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Nov. 10, 2014, 11:14 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27841/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 11:14 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, John Speidel, and Sid Wagle.
> 
> 
> Bugs: AMBARI-8264
>     https://issues.apache.org/jira/browse/AMBARI-8264
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The embedded DB creation sctipt: src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql incorrectly creates the cluster_version table in the wrong schema.
> CREATE TABLE cluster_version (...)
> It should be:
> CREATE TABLE ambari.cluster_version (...)
> This will cause a failure when creating a cluster stating that the relation cluster_version doesn't exist.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a8b92e7 
> 
> Diff: https://reviews.apache.org/r/27841/diff/
> 
> 
> Testing
> -------
> 
> Copied the change sql file to a host after running yum install ambari-server -y and before ambari-server setup -s.
> Then verified that the table was created correctly,
> psql -U ambari -d ambari
> \d
> \d cluster_version
> \d host_version
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 27841: Ambari DB DDL create script doesn't properly create table cluster_version

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27841/#review60714
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Nov. 10, 2014, 6:14 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27841/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 6:14 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, John Speidel, and Sid Wagle.
> 
> 
> Bugs: AMBARI-8264
>     https://issues.apache.org/jira/browse/AMBARI-8264
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The embedded DB creation sctipt: src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql incorrectly creates the cluster_version table in the wrong schema.
> CREATE TABLE cluster_version (...)
> It should be:
> CREATE TABLE ambari.cluster_version (...)
> This will cause a failure when creating a cluster stating that the relation cluster_version doesn't exist.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a8b92e7 
> 
> Diff: https://reviews.apache.org/r/27841/diff/
> 
> 
> Testing
> -------
> 
> Copied the change sql file to a host after running yum install ambari-server -y and before ambari-server setup -s.
> Then verified that the table was created correctly,
> psql -U ambari -d ambari
> \d
> \d cluster_version
> \d host_version
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>