You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 09:19:36 UTC

[GitHub] [arrow-rs] jhorstmann commented on pull request #314: return reference from DictionaryArray::values() (#313)

jhorstmann commented on pull request #314:
URL: https://github.com/apache/arrow-rs/pull/314#issuecomment-843005564


   Nice! While we're looking at the DictionaryArray and introducing api changes, we should also remove the `keys_array` method since the same functionality is now provided by the `keys` method. The `keys_array` has measurable overhead when used in inner loops also due to clones. Some time ago, `keys` only returned an iterator and `keys_array` had its uses, but now it's fully redundant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org