You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by Antoine Toulme <an...@toulme.name> on 2021/12/24 07:10:25 UTC
Anyone interested in reviewing this pull request to move to Java 17?
Hey folks,
Anyone interested in reviewing this PR?
https://github.com/apache/incubator-tuweni/pull/343/files <https://github.com/apache/incubator-tuweni/pull/343/files>
Is it a good time to move to Java 17, or should we do one more release before we move?
Antoine
Re: Anyone interested in reviewing this pull request to move to Java 17?
Posted by larry mccay <lm...@apache.org>.
+1 to stay on 11 as a requirement.
IMO, a project that is primarily a library to be used by others needs to
not require upgrade by consumers and to target the largest consumer base as
possible.
On Fri, Dec 24, 2021 at 3:35 AM Antoine Toulme <an...@toulme.name> wrote:
> The PR is currently mandating Java 17 source and target levels. We can use
> Java 11 for now (we already moved to 11 a while back).
>
> There is no specific feature of 17 I’m looking for, but I need to make
> sure we support it. The enhancements in the PR are mostly around Gradle and
> a new license check.
>
> I’ll change the compile source and target to 11 — that’s good feedback,
> thanks.
>
> > On Dec 23, 2021, at 11:20 PM, Adrian Sutton <ad...@consensys.net.INVALID>
> wrote:
> >
> > I won’t have time to look at the PR tonight but can in a few days.
> >
> >> Is it a good time to move to Java 17, or should we do one more release
> before we move?
> >
> > I’d say it’s pretty early to be moving to Java 17 as a requirement.
> AdoptOpenJDK are planning to support java 8 until at least 2026 and Java 11
> until at least 2024. Plus Java 17 is only a few months old so loads of
> users won’t have had time to upgrade yet.
> >
> > Is there are anything in particular you wanted to use that’s only
> available in Java 17?
> >
> > Cheers,
> > Adrian.
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> > For additional commands, e-mail: dev-help@tuweni.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>
Re: Anyone interested in reviewing this pull request to move to Java 17?
Posted by Antoine Toulme <an...@toulme.name>.
The PR is currently mandating Java 17 source and target levels. We can use Java 11 for now (we already moved to 11 a while back).
There is no specific feature of 17 I’m looking for, but I need to make sure we support it. The enhancements in the PR are mostly around Gradle and a new license check.
I’ll change the compile source and target to 11 — that’s good feedback, thanks.
> On Dec 23, 2021, at 11:20 PM, Adrian Sutton <ad...@consensys.net.INVALID> wrote:
>
> I won’t have time to look at the PR tonight but can in a few days.
>
>> Is it a good time to move to Java 17, or should we do one more release before we move?
>
> I’d say it’s pretty early to be moving to Java 17 as a requirement. AdoptOpenJDK are planning to support java 8 until at least 2026 and Java 11 until at least 2024. Plus Java 17 is only a few months old so loads of users won’t have had time to upgrade yet.
>
> Is there are anything in particular you wanted to use that’s only available in Java 17?
>
> Cheers,
> Adrian.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: Anyone interested in reviewing this pull request to move to Java 17?
Posted by Adrian Sutton <ad...@consensys.net.INVALID>.
I won’t have time to look at the PR tonight but can in a few days.
> Is it a good time to move to Java 17, or should we do one more release before we move?
I’d say it’s pretty early to be moving to Java 17 as a requirement. AdoptOpenJDK are planning to support java 8 until at least 2026 and Java 11 until at least 2024. Plus Java 17 is only a few months old so loads of users won’t have had time to upgrade yet.
Is there are anything in particular you wanted to use that’s only available in Java 17?
Cheers,
Adrian.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org