You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "saber-wang (via GitHub)" <gi...@apache.org> on 2025/06/09 06:05:10 UTC

[PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

saber-wang opened a new pull request, #758:
URL: https://github.com/apache/skywalking-java/pull/758

   <!--
       ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
       maybe closed without notice.
       Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
       Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
   -->
   
   <!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [ ] Explain briefly why the bug exists and how to fix it.
        ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
   
   <!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
   ### Add an agent plugin to support <framework name>
   - [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
   - [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
        ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
   
   <!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
   ### Improve the performance of <class or module or ...>
   - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
   - [ ] The benchmark result.
   ```text
   <Paste the benchmark results here>
   ```
   - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
        ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
   
   <!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
        ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#issuecomment-2955324075

   I don mean removing from doc. I mean in other PR, you could see there is a PR in UI repo.
   For this, we would require that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#discussion_r2135246240


##########
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java:
##########
@@ -262,4 +262,7 @@ public class ComponentsDefine {
     public static final OfficialComponent CAFFEINE = new OfficialComponent(160, "Caffeine");
 
     public static final OfficialComponent THREAD_PER_TASK_EXECUTOR = new OfficialComponent(161, "ThreadPerTask-executor");
+
+    public static final OfficialComponent DMDB_JDBC_DRIVER = new OfficialComponent(162, "Dmdb-jdbc-driver");

Review Comment:
   And considering the license issue, we would not require adding dameng DB logo into the UI repo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#issuecomment-2954948623

   I think that although you added this parser, the DB connection must be managed by supported JDBC pooling. Right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "saber-wang (via GitHub)" <gi...@apache.org>.
saber-wang commented on PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#issuecomment-2957418410

   Thanks a lot for the help 🙏!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#discussion_r2136767862


##########
CHANGES.md:
##########
@@ -12,6 +12,7 @@ Release Notes.
   initialization. Delay so11y metrics#build when the services are not ready to avoid MeterService status is not
   initialized.
 * Fix retransform failure when enhancing both parent and child classes.
+* Add support for `dameng(DM)` jdbc url format in `URLParser`.

Review Comment:
   ```suggestion
   * Add support for `dameng(DM)` JDBC url format in `URLParser`.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "saber-wang (via GitHub)" <gi...@apache.org>.
saber-wang commented on PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#issuecomment-2955266109

   > I think that although you added this parser, the DB connection must be managed by supported JDBC pooling. Right?
   
   Yes, because this is a standard JDBC driver, so using something like HikariCP is absolutely fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#discussion_r2135245038


##########
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java:
##########
@@ -262,4 +262,7 @@ public class ComponentsDefine {
     public static final OfficialComponent CAFFEINE = new OfficialComponent(160, "Caffeine");
 
     public static final OfficialComponent THREAD_PER_TASK_EXECUTOR = new OfficialComponent(161, "ThreadPerTask-executor");
+
+    public static final OfficialComponent DMDB_JDBC_DRIVER = new OfficialComponent(162, "Dmdb-jdbc-driver");

Review Comment:
   You need to register this ID in the main repo first. Please follow plugin contribution doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#discussion_r2135620363


##########
docs/en/setup/service-agent/java-agent/Supported-list.md:
##########
@@ -185,6 +185,7 @@ The meter plugin provides the advanced metrics collections, which are not a part
     * [DB2](https://www.ibm.com/products/db2/database)
     * Sybase
     * [OceanBase](https://www.oceanbase.com/)
+    * DM

Review Comment:
   Please revert this to have a link.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) JDBC URL format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #758:
URL: https://github.com/apache/skywalking-java/pull/758


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#issuecomment-2955634797

   I mean you don't need this. https://github.com/apache/skywalking-booster-ui/pull/403/files 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add support for dameng(DM) jdbc url format in URLParser [skywalking-java]

Posted by "saber-wang (via GitHub)" <gi...@apache.org>.
saber-wang commented on PR #758:
URL: https://github.com/apache/skywalking-java/pull/758#issuecomment-2955485925

   @wu-sheng  
   I'm sorry, I've gone through the related PR and guidelines once more, but I'm still not entirely clear on what UI this is referring to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org