[jira] (MDEP-285) Document abstract method org.apache.maven.plugin.dependency.AbstractDependencyFilterMojo.getMarkedArtifactFilter()

["Herve Boutemy (JIRA)" <ji...@codehaus.org>]

     [ https://jira.codehaus.org/browse/MDEP-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Herve Boutemy closed MDEP-285.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.6
         Assignee: Herve Boutemy  (was: Brian Fox)

patch applied in [r1400737|http://svn.apache.org/viewvc?rev=1400737&view=rev]

thank you
                
> Document abstract method org.apache.maven.plugin.dependency.AbstractDependencyFilterMojo.getMarkedArtifactFilter()
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: MDEP-285
>                 URL: https://jira.codehaus.org/browse/MDEP-285
>             Project: Maven 2.x Dependency Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1
>            Reporter: Baptiste MATHUS
>            Assignee: Herve Boutemy
>            Priority: Trivial
>             Fix For: 2.6
>
>         Attachments: getMarkedArtifactFilter-javadoc.patch
>
>
> As this method is the only abstract method, it's a pity it's the only one that's undocumented :). Mainly, it's difficult to know without digging into/reading all the code if the filtering is going keep what's returned, or the contrary.
> Note that org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter.class is also undocumented. Naming let developer have an idea of it should do, but it'd be clearer with some javadoc :).
> Cheers
> PS : I'm attaching a proposed patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira