You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/02/03 15:19:44 UTC

[GitHub] [trafficserver] ywkaras opened a new issue #7475: Core plugins are setting pcre_malloc and pcre_free.

ywkaras opened a new issue #7475:
URL: https://github.com/apache/trafficserver/issues/7475


   ```
   wkaras ~/REPOS/TS
   M$ grep 'pcre_malloc *=' $(findsrc)
   ./plugins/regex_revalidate/regex_revalidate.c:  pcre_malloc = &ts_malloc;
   ./plugins/experimental/cookie_remap/cookie_remap.cc:  pcre_malloc = &ink_malloc;
   ./plugins/regex_remap/regex_remap.cc:  pcre_malloc = &ts_malloc;
   ./src/traffic_server/traffic_server.cc:  pcre_malloc = ats_malloc;
   wkaras ~/REPOS/TS
   M$ grep 'pcre_free *=' $(findsrc)
   ./plugins/regex_revalidate/regex_revalidate.c:  pcre_free   = &ts_free;
   ./plugins/experimental/cookie_remap/cookie_remap.cc:  pcre_free   = &ink_free;
   ./plugins/regex_remap/regex_remap.cc:  pcre_free   = &ts_free;
   ./src/traffic_server/traffic_server.cc:  pcre_free   = ats_free;
   wkaras ~/REPOS/TS
   M$
   ```
   This is probably just a cosmetic problem.  But, generally, plugins should not assume they are exclusively using global variables they don't define.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras closed issue #7475: Core plugins are setting pcre_malloc and pcre_free.

Posted by GitBox <gi...@apache.org>.
ywkaras closed issue #7475:
URL: https://github.com/apache/trafficserver/issues/7475


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras commented on issue #7475: Core plugins are setting pcre_malloc and pcre_free.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on issue #7475:
URL: https://github.com/apache/trafficserver/issues/7475#issuecomment-797093426


   I will investigate the various wrappers for std malloc and free.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org