[jira] [Commented] (HADOOP-10058) TestMetricsSystemImpl fails on trunk

["Akira AJISAKA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798614#comment-13798614 ] 

Akira AJISAKA commented on HADOOP-10058:
----------------------------------------

The test fails at
{code}
    //When we call stop, at most two sources will be consumed by each sink thread.
    verify(sink1, atMost(2)).putMetrics(r1.capture());
{code}

IMO, TestSink.putMetrics() is called at most three times because there are three sources to be consumed. The three sources are s0rec, s1rec, and MetricsSystem.
I change the test code and attach a patch soon.

> TestMetricsSystemImpl fails on trunk
> ------------------------------------
>
>                 Key: HADOOP-10058
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10058
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 3.0.0
>         Environment: Mac OS 10.8, Java7u40
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>         Attachments: org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl-output_SUCCESS.txt, org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl-output.txt, org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl_SUCCESS.txt, org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl.txt
>
>
> Here is the output when I executed "mvn test -Dtest=TestMetricsSystemImpl".
> {code}
> Failed tests: 
>   TestMetricsSystemImpl.testInitFirstVerifyStopInvokedImmediately:114 
> Wanted at most 2 times but was 3
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0
> {code}
> I found the test doesn't always fail. The test sometimes success.



--
This message was sent by Atlassian JIRA
(v6.1#6144)