[GitHub] eiri commented on a change in pull request #1770: Fix function_clause exception on invalid DB security objects

[GitBox <gi...@apache.org>]

eiri commented on a change in pull request #1770: Fix function_clause exception on invalid DB security objects
URL: https://github.com/apache/couchdb/pull/1770#discussion_r237980989
 
 

 ##########
 File path: src/couch/src/couch_db.erl
 ##########
 @@ -736,19 +736,23 @@ validate_security_object(SecProps) ->
 
 % validate user input
 validate_names_and_roles({Props}) when is_list(Props) ->
-    case couch_util:get_value(<<"names">>,Props,[]) of
+    case couch_util:get_value(<<"names">>, Props, []) of
     Ns when is_list(Ns) ->
             [throw("names must be a JSON list of strings") ||N <- Ns, not is_binary(N)],
             Ns;
-    _ -> throw("names must be a JSON list of strings")
+    _ ->
+        throw("names field vallue must be a list of strings")
     end,
-    case couch_util:get_value(<<"roles">>,Props,[]) of
+    case couch_util:get_value(<<"roles">>, Props, []) of
     Rs when is_list(Rs) ->
         [throw("roles must be a JSON list of strings") ||R <- Rs, not is_binary(R)],
         Rs;
-    _ -> throw("roles must be a JSON list of strings")
+    _ ->
+        throw("roles field vallue must be a list of strings")
 
 Review comment:
   same typo here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services