You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/03/26 15:52:40 UTC

Re: [PR] ORC-1665: Migrate to `importOrder` of `spotless-maven-plugin` [orc]

cxzl25 commented on code in PR #1860:
URL: https://github.com/apache/orc/pull/1860#discussion_r1539541439


##########
java/core/src/java/org/apache/orc/InMemoryKeystore.java:
##########
@@ -330,4 +330,3 @@ private byte[] getMaterial() {
   }
 
 }
-

Review Comment:
   > Please make a new PR for the end line change separately before all of these migration.
   
   OK
   
   > we need a way to prevent any future regression in terms of the end line
   
   Now `spotless-maven-plugin` will check this behavior, so the beginning of the CI failed at the beginning.
   
   https://github.com/apache/orc/actions/runs/8437582330/job/23107719304#step:5:8408
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org