You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/12 20:10:28 UTC
[GitHub] [kafka] hachikuji opened a new pull request, #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits
hachikuji opened a new pull request, #12626:
URL: https://github.com/apache/kafka/pull/12626
Asynchronous offset commits may throw an unexpected `WakeupException` following https://github.com/apache/kafka/pull/11631 and https://github.com/apache/kafka/pull/12244. This patch fixes the problem by passing through a flag to `ensureCoordinatorReady` to indicate whether wakeups should be disabled.
Note: this patch builds on top of https://github.com/apache/kafka/pull/12611.
Co-Authored-By: Guozhang Wang <wa...@gmail.com>
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12626:
URL: https://github.com/apache/kafka/pull/12626#issuecomment-1244881797
I can take a look when I'm available today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12626:
URL: https://github.com/apache/kafka/pull/12626#issuecomment-1245023780
Failed tests are unrelated:
```
org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
kafka.test.ClusterTestExtensionsTest.[1] Type=ZK, Name=Generated Test, MetadataVersion=3.3-IV3, Security=PLAINTEXT
org.apache.kafka.streams.processor.internals.StreamsAssignmentScaleTest.testHighAvailabilityTaskAssignorManyStandbys
org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits
Posted by GitBox <gi...@apache.org>.
hachikuji commented on PR #12626:
URL: https://github.com/apache/kafka/pull/12626#issuecomment-1244875608
@showuon Thanks! I appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits
Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #12626:
URL: https://github.com/apache/kafka/pull/12626#discussion_r969036313
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java:
##########
@@ -211,8 +211,23 @@ public void poll(RequestFuture<?> future) {
* @throws InterruptException if the calling thread is interrupted
*/
public boolean poll(RequestFuture<?> future, Timer timer) {
+ return poll(future, timer, false);
+ }
+
+ /**
+ * Block until the provided request future request has finished or the timeout has expired.
+ *
+ * @param future The request future to wait for
+ * @param timer Timer bounding how long this method can block
+ * @param disableWakeup true if we should not check for wakeups, false otherwise
+ *
+ * @return true if the future is done, false otherwise
+ * @throws WakeupException if {@link #wakeup()} is called from another thread
Review Comment:
We should mention `WakeupException` only throws when `disableWakeup` is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits
Posted by GitBox <gi...@apache.org>.
showuon merged PR #12626:
URL: https://github.com/apache/kafka/pull/12626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #12626: KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits
Posted by GitBox <gi...@apache.org>.
hachikuji commented on PR #12626:
URL: https://github.com/apache/kafka/pull/12626#issuecomment-1244877452
I have been seeing some recent build failures due to a non-zero exit code from `core:unitTest`. I cannot reproduce locally (of course) and this is making it tough to get some of these 3.3 patches over the line. I'll take a look tomorrow if I can, but if anyone has any ideas, do let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org