You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Vince Ford <vf...@pivotal.io> on 2015/12/10 20:29:57 UTC
Review Request 41219: GEODE-503: Addresses config passwords written
to logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41219/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
Prevents configuration passwords from being written to log files
for keystores used by SSL or any config parameter with the
keyword password in its name.
Adds unit test to validate AbstractConfigJUnitTest
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 2f2f0f79ebc5ba9620814cb8a6d0610a2c3a4a78
gemfire-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/41219/diff/
Testing
-------
AbstractConfigJUnitTest
Manual confirmation that changes work as expected via log file review
Thanks,
Vince Ford
Re: Review Request 41219: GEODE-503: Addresses config passwords
written to logs
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41219/#review109845
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Dec. 10, 2015, 11:29 a.m., Vince Ford wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41219/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 11:29 a.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Prevents configuration passwords from being written to log files
> for keystores used by SSL or any config parameter with the
> keyword password in its name.
>
> Adds unit test to validate AbstractConfigJUnitTest
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 2f2f0f79ebc5ba9620814cb8a6d0610a2c3a4a78
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/AbstractConfigJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41219/diff/
>
>
> Testing
> -------
>
> AbstractConfigJUnitTest
> Manual confirmation that changes work as expected via log file review
>
>
> Thanks,
>
> Vince Ford
>
>