[jira] [Updated] (SOLR-3038) Solrj should use javabin wireformat by default with updaterequests

["Shawn Heisey (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Heisey updated SOLR-3038:
-------------------------------

    Attachment: SOLR-3038-abstract-writer.patch

The extremely simple fix for this is to simply change one line in HttpSolrServer, so it creates its request writer as BinaryRequestWriter.

This attached patch (missing CHANGES.txt) goes further.  In addition to the simple one-line fix, it turns RequestWriter into an abstract class and creates XMLRequestWriter as an implementation.

I'm running tests now, if there are failures I will adjust it.  There could be code out there that will break with this change, so I'd like to know if this is a bad idea for 4.x.
                
> Solrj should use javabin wireformat by default with updaterequests
> ------------------------------------------------------------------
>
>                 Key: SOLR-3038
>                 URL: https://issues.apache.org/jira/browse/SOLR-3038
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 4.0-ALPHA
>            Reporter: Sami Siren
>            Priority: Minor
>         Attachments: SOLR-3038-abstract-writer.patch
>
>
> The javabin wire format is faster than xml when feeding Solr - it should become the default. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org