You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/27 19:36:03 UTC

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17155: Optimize ShardingTableBroadcastRoutingEngine and SingleTableSQLRouter logic for PostgreSQL schema

codecov-commenter commented on PR #17155:
URL: https://github.com/apache/shardingsphere/pull/17155#issuecomment-1111404424

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17155](https://codecov.io/gh/apache/shardingsphere/pull/17155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e252d5) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6533e51bf73c6c9c95a7faf7a677a0a24d90814b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6533e51) will **increase** coverage by `0.11%`.
   > The diff coverage is `39.13%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17155      +/-   ##
   ============================================
   + Coverage     60.26%   60.38%   +0.11%     
   - Complexity     2114     2115       +1     
   ============================================
     Files          3490     3492       +2     
     Lines         52192    52213      +21     
     Branches       8883     8889       +6     
   ============================================
   + Hits          31456    31530      +74     
   + Misses        18100    18038      -62     
   - Partials       2636     2645       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...resher/type/DropIndexStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9Ecm9wSW5kZXhTdGF0ZW1lbnRTY2hlbWFSZWZyZXNoZXIuamF2YQ==) | `13.63% <0.00%> (+3.95%)` | :arrow_up: |
   | [...sphere/singletable/route/SingleTableSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvcm91dGUvU2luZ2xlVGFibGVTUUxSb3V0ZXIuamF2YQ==) | `62.06% <50.00%> (ø)` | |
   | [.../route/engine/type/ShardingRouteEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvU2hhcmRpbmdSb3V0ZUVuZ2luZUZhY3RvcnkuamF2YQ==) | `68.67% <100.00%> (+0.43%)` | :arrow_up: |
   | [...broadcast/ShardingTableBroadcastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvYnJvYWRjYXN0L1NoYXJkaW5nVGFibGVCcm9hZGNhc3RSb3V0aW5nRW5naW5lLmphdmE=) | `68.00% <100.00%> (+0.65%)` | :arrow_up: |
   | [.../infra/metadata/schema/util/IndexMetaDataUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvdXRpbC9JbmRleE1ldGFEYXRhVXRpbC5qYXZh) | `80.00% <100.00%> (+2.22%)` | :arrow_up: |
   | [...est/column/value/impl/MySQLUnsignedIntHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRJbnRIYW5kbGVyLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [...column/value/impl/MySQLUnsignedTinyintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRUaW55aW50SGFuZGxlci5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [...olumn/value/impl/MySQLUnsignedSmallintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRTbWFsbGludEhhbmRsZXIuamF2YQ==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [...lumn/value/impl/MySQLUnsignedMediumintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRNZWRpdW1pbnRIYW5kbGVyLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [.../column/value/impl/MySQLUnsignedBigintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRCaWdpbnRIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | ... and [20 more](https://codecov.io/gh/apache/shardingsphere/pull/17155/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17155?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17155?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6533e51...5e252d5](https://codecov.io/gh/apache/shardingsphere/pull/17155?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org