You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/22 15:48:00 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13726: feat(native-filters): Add default first value to select filter
codecov[bot] commented on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/daefebb49deb255dad8514d62b6887ca1a00a723?el=desc) (daefebb) will **decrease** coverage by `4.28%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head b070c1c. Consider uploading reports for the commit b070c1c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 77.39% 73.10% -4.29%
==========================================
Files 928 626 -302
Lines 47024 22229 -24795
Branches 5812 5797 -15
==========================================
- Hits 36393 16251 -20142
+ Misses 10488 5836 -4652
+ Partials 143 142 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+0.06%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-0.02%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/nativeFilters/FilterBar/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| [...components/nativeFilters/FilterBar/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclZhbHVlLnRzeA==) | `69.09% <0.00%> (-16.37%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `81.25% <0.00%> (-11.18%)` | :arrow_down: |
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `76.54% <0.00%> (-9.88%)` | :arrow_down: |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `95.65% <0.00%> (-4.35%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
| ... and [327 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [daefebb...b070c1c](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org