You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/01/10 16:55:13 UTC
[GitHub] [brooklyn-docs] jcabrerizo opened a new pull request #300: Session
expiring configuration
jcabrerizo opened a new pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300
Describes how to config the session expiring and what is the its default behavior
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] tbouron merged pull request #300: Session expiring
configuration
Posted by GitBox <gi...@apache.org>.
tbouron merged pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] geomacy commented on a change in pull request #300:
Session expiring configuration
Posted by GitBox <gi...@apache.org>.
geomacy commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r365613164
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,23 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+This class marks as used the session on the other modules by resetting the max inactive interval and also allows to
+set up a max age time for the sessions, if not, it will be managed by Jetty the server.
Review comment:
don't quite understand this - if not what?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] jcabrerizo commented on a change in pull request
#300: Session expiring configuration
Posted by GitBox <gi...@apache.org>.
jcabrerizo commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r365706249
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,23 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+This class marks as used the session on the other modules by resetting the max inactive interval and also allows to
+set up a max age time for the sessions, if not, it will be managed by Jetty the server.
Review comment:
Hi Geoff, I added more detail. A larger explanation of the flow can be found on the javadoc of the class. I was trying to keep this documentation not to much connected to the internal java flow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] jcabrerizo commented on a change in pull request
#300: Session expiring configuration
Posted by GitBox <gi...@apache.org>.
jcabrerizo commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r367346283
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,34 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+For choosing the preferred session for a given request you should call one of the static methods `of` in the class.
+It will look on the server for a previously marked _preferred session handler_ and then, for the _preferred session_ on
Review comment:
I re wrote the sentence
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #300:
Session expiring configuration
Posted by GitBox <gi...@apache.org>.
tbouron commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r367320973
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,34 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+For choosing the preferred session for a given request you should call one of the static methods `of` in the class.
Review comment:
`s/For choosing/To choose/`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #300:
Session expiring configuration
Posted by GitBox <gi...@apache.org>.
tbouron commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r367327140
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,23 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+This class marks as used the session on the other modules by resetting the max inactive interval and also allows to
+set up a max age time for the sessions, if not, it will be managed by Jetty the server.
Review comment:
@jcabrerizo I think the issue is that it's missing a dot. The sentence should stops at `... age time for the sessions.` rather than continuing with a comma.
Also at the end: `s/Jetty the server/the Jetty server`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #300:
Session expiring configuration
Posted by GitBox <gi...@apache.org>.
tbouron commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r367321984
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,34 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+For choosing the preferred session for a given request you should call one of the static methods `of` in the class.
+It will look on the server for a previously marked _preferred session handler_ and then, for the _preferred session_ on
Review comment:
`s/and then, for the _preferred session_ on it./as well as a _preferred session_/`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #300:
Session expiring configuration
Posted by GitBox <gi...@apache.org>.
tbouron commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r367322225
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,34 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+For choosing the preferred session for a given request you should call one of the static methods `of` in the class.
+It will look on the server for a previously marked _preferred session handler_ and then, for the _preferred session_ on
+it. If there is not _preferred session handler_, a new one will be created on the CXF bundle. If there is not a
Review comment:
`s/If there is not/If there is no` 2 times
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-docs] geomacy commented on a change in pull request #300:
Session expiring configuration
Posted by GitBox <gi...@apache.org>.
geomacy commented on a change in pull request #300: Session expiring configuration
URL: https://github.com/apache/brooklyn-docs/pull/300#discussion_r365613246
##########
File path: guide/ops/configuration/brooklyn_cfg.md
##########
@@ -185,9 +185,23 @@ or
[EntitlementManager]({{book.url.brooklyn_javadoc}}/org/apache/brooklyn/api/mgmt/entitlement/EntitlementManager.html).
-
## HTTPS Configuration
See [HTTPS Configuration]({{book.path.docs}}/ops/configuration/https.md) for general information on configuring HTTPS.
+## Session configuration
+
+Apache Brooklyn uses a util class, `org.apache.brooklyn.rest.util.MultiSessionAttributeAdapter` for ensuring requests
+in different bundles can get a consistent shared view of the data stored in the session.
+
+This class marks as used the session on the other modules by resetting the max inactive interval and also allows to
Review comment:
Could you add a bit of detail here, this is quite terse - maybe describe the flow a little? "When a request on a given session is received...."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services