You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/23 07:06:09 UTC
[GitHub] [apisix] harmseru opened a new issue, #8381: feat: As a user of limit-count, I want to communicate the X-RateLimit-Reset header so my api consumers know when their next allocation window starts, this should be communicated on every response even the rejected response.
harmseru opened a new issue, #8381:
URL: https://github.com/apache/apisix/issues/8381
### Description
- limit-count plugin does not communicate the `X-RateLimit-Reset` header only `X-RateLimit-Remaining` and `X-RateLimit-Limit`
- There are no `X-RateLimit-*` headers communicated on a rejected response, here I believe it can be improved to include the 'X-RateLimit-Reset` header as per draft [RFC](https://www.ietf.org/archive/id/draft-polli-ratelimit-headers-02.html#name-ratelimit-reset).
The improvement of this approach would be that consumers of an API know when they can attempt another API call without having to "poll" for sucessful responses with Retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #8381: feat: As a user of limit-count, I want to communicate the X-RateLimit-Reset header so my api consumers know when their next allocation window starts, this should be communicated on every response even the rejected response.
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #8381:
URL: https://github.com/apache/apisix/issues/8381#issuecomment-1324653918
We need to modify the code to record the time when we start to count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #8381: feat: As a user of limit-count, I want to communicate the X-RateLimit-Reset header so my api consumers know when their next allocation window starts, this should be communicated on every response even the rejected response.
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #8381: feat: As a user of limit-count, I want to communicate the X-RateLimit-Reset header so my api consumers know when their next allocation window starts, this should be communicated on every response even the rejected response.
URL: https://github.com/apache/apisix/issues/8381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] mscb402 commented on issue #8381: feat: As a user of limit-count, I want to communicate the X-RateLimit-Reset header so my api consumers know when their next allocation window starts, this should be communicated on every response even the rejected response.
Posted by GitBox <gi...@apache.org>.
mscb402 commented on issue #8381:
URL: https://github.com/apache/apisix/issues/8381#issuecomment-1327056407
please assign to me @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #8381: feat: As a user of limit-count, I want to communicate the X-RateLimit-Reset header so my api consumers know when their next allocation window starts, this should be communicated on every response even the rejected response.
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #8381:
URL: https://github.com/apache/apisix/issues/8381#issuecomment-1324645779
I think this could be a good first issue. cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org