[GitHub] [spark] HeartSaVioR edited a comment on issue #26173: [SPARK-29503][SQL] Copy result row from RowWriter in GenerateUnsafeProjection when the expression is lambdaFunction in MapObject

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on issue #26173: [SPARK-29503][SQL] Copy result row from RowWriter in GenerateUnsafeProjection when the expression is lambdaFunction in MapObject
URL: https://github.com/apache/spark/pull/26173#issuecomment-544501266
 
 
   I've changed the approach to what @cloud-fan had suggested. 
   
   It has to pass a data type to check nested struct and copy unsafe data, so it needs to serialize data type to JSON and deserialize in method. Hope this is OK given we only do once per generating code for MapObjects.
   
   I'd like to see whether the direction is OK - if we agree with the direction, I'll try to refine the code as well as add some UTs for new methods.
   
   In case of rolling back, previous commit head is here:
   https://github.com/HeartSaVioR/spark/commits/8b2be7116f61df17c7e538d026a7b82b94bf0f12

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org