You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/01/30 10:22:04 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #23841: Replace `DefaultShardingStrategyResultSet`
Qianyi951015 opened a new pull request, #23841:
URL: https://github.com/apache/shardingsphere/pull/23841
For #23772.
Changes proposed in this pull request:
- Replace `DefaultShardingStrategyResultSet` with `ShowDefaultShardingStrategyExecutor`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23841: Replace `DefaultShardingStrategyResultSet`
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #23841:
URL: https://github.com/apache/shardingsphere/pull/23841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23841: Replace `DefaultShardingStrategyResultSet`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23841:
URL: https://github.com/apache/shardingsphere/pull/23841#issuecomment-1408400226
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23841](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d76632) into [master](https://codecov.io/gh/apache/shardingsphere/commit/28456fc1c23c5dbf3642d831109325c76e5d45f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28456fc) will **decrease** coverage by `0.05%`.
> The diff coverage is `31.12%`.
```diff
@@ Coverage Diff @@
## master #23841 +/- ##
============================================
- Coverage 50.26% 50.21% -0.05%
+ Complexity 1575 1574 -1
============================================
Files 3236 3239 +3
Lines 53392 53477 +85
Branches 9759 9784 +25
============================================
+ Hits 26837 26854 +17
- Misses 24205 24270 +65
- Partials 2350 2353 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...k/consistency/DataConsistencyCheckIgnoredType.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9jaGVjay9jb25zaXN0ZW5jeS9EYXRhQ29uc2lzdGVuY3lDaGVja0lnbm9yZWRUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/consistency/DataConsistencyCheckResult.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9jaGVjay9jb25zaXN0ZW5jeS9EYXRhQ29uc2lzdGVuY3lDaGVja1Jlc3VsdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...eline/api/ingest/position/NoUniqueKeyPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9pbmdlc3QvcG9zaXRpb24vTm9VbmlxdWVLZXlQb3NpdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...api/ingest/position/PrimaryKeyPositionFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9pbmdlc3QvcG9zaXRpb24vUHJpbWFyeUtleVBvc2l0aW9uRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pipeline/api/pojo/ConsistencyCheckJobItemInfo.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9wb2pvL0NvbnNpc3RlbmN5Q2hlY2tKb2JJdGVtSW5mby5qYXZh) | `0.00% <ø> (ø)` | |
| [...ta/pipeline/spi/sqlbuilder/PipelineSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NwaS9zcWxidWlsZGVyL1BpcGVsaW5lU1FMQnVpbGRlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...stency/ConsistencyCheckJobItemProgressContext.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2NvbnNpc3RlbmN5L0NvbnNpc3RlbmN5Q2hlY2tKb2JJdGVtUHJvZ3Jlc3NDb250ZXh0LmphdmE=) | `0.00% <ø> (ø)` | |
| [.../data/pipeline/core/importer/DataRecordMerger.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2ltcG9ydGVyL0RhdGFSZWNvcmRNZXJnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ata/pipeline/core/importer/DataSourceImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2ltcG9ydGVyL0RhdGFTb3VyY2VJbXBvcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/pipeline/core/ingest/dumper/InventoryDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2luZ2VzdC9kdW1wZXIvSW52ZW50b3J5RHVtcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/shardingsphere/pull/23841?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org