You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/16 01:09:19 UTC
[GitHub] [incubator-hudi] yihua opened a new pull request #1234: [MINOR]
Make constant fields final in HoodieTestDataGenerator
yihua opened a new pull request #1234: [MINOR] Make constant fields final in HoodieTestDataGenerator
URL: https://github.com/apache/incubator-hudi/pull/1234
## What is the purpose of the pull request
Make constant fields final in `HoodieTestDataGenerator` class and rename them based on the naming convention.
## Brief change log
As above.
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf merged pull request #1234: [MINOR] Make
constant fields final in HoodieTestDataGenerator
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1234: [MINOR] Make constant fields final in HoodieTestDataGenerator
URL: https://github.com/apache/incubator-hudi/pull/1234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1234: [MINOR] Make
constant fields final in HoodieTestDataGenerator
Posted by GitBox <gi...@apache.org>.
hmatu commented on issue #1234: [MINOR] Make constant fields final in HoodieTestDataGenerator
URL: https://github.com/apache/incubator-hudi/pull/1234#issuecomment-574964656
Great job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services