[GitHub] [spark] huaxingao commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

[GitBox <gi...@apache.org>]

huaxingao commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-651250226


   @zhengruifeng 
   Thanks for your comments.
   Seems I have to add summary to each of the Classifiers one by one. Using this PR as an example, I think I need to have the following in RandomForestclassifier.scala, to be consistent with the implementation of LogisticRegressionTrainingSummary.
   ```
   sealed trait RandomForestClassificationSummary extends ClassificationSummary 
   
   sealed trait RandomForestClassificationTrainingSummary extends RandomForestClassificationSummary
     with TrainingSummary
   
   sealed trait BinaryRandomForestClassificationSummary extends BinaryClassificationSummary
   
   sealed trait BinaryRandomForestClassificationTrainingSummary extends
     BinaryRandomForestClassificationSummary with RandomForestClassificationTrainingSummary
   
   private class RandomForestClassificationTrainingSummaryImpl
   
   private class RandomForestClassificationSummaryImpl
   
   private class BinaryRandomForestClassificationTrainingSummaryImpl
   
   private class BinaryRandomForestClassificationSummaryImpl
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org