You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/01/15 13:41:10 UTC
[GitHub] [qpid-dispatch] 4383 opened a new pull request #981: [trivial] Fix path in doc example
4383 opened a new pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981
qpid-proton subdirectories have been inversed in the doc.
Please take a look to:
https://github.com/apache/qpid-proton/blob/master/python/examples/simple_recv.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] 4383 commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
4383 commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-762394764
Thanks for details.
I haven't preference...
As long as the documentation matches the reality, that's fine with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-761551329
(I forgot to consider, before, that we are talking about qpid-proton examples here; in the qpid-proton repo.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] 4383 commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
4383 commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-762330481
> (I forgot to consider, before, that we are talking about qpid-proton examples here; in the qpid-proton repo.)
@jiridanek I'm not sure what you meant by saying that. Do you want to propose something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] 4383 commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
4383 commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-761065144
> I believe the original text is correct. Are you looking at the source directory structure or the installed directory structure? The documentation is referring to the installed artifacts.
As this is an example I was looking at the source directory.
I didn't try to build qpid-proton maybe I should have started by that :)
In this case it could be worth to indicate the build step in the documentation.
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] 4383 commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
4383 commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-761546347
I think you're right, the documentation is right, `__<install-dir>__` is explicit.
I'm going to close this PR.
Thanks for your time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-761070691
Well, the paths in the doc start with `__<install-dir>__`.
Ultimately, I'd prefer to have the same path for both sources and install. The `examples` part of the path is more important than the fact it is written in python, so in both cases I'd put that first. Grouping things according to technology is sometimes reasonable and necessary; in this case I think it is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-761285995
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/981?src=pr&el=h1) Report
> Merging [#981](https://codecov.io/gh/apache/qpid-dispatch/pull/981?src=pr&el=desc) (0ad9adc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b46366762aeebcf3f03f03c200f0b6d2e3d5688e?el=desc) (b463667) will **decrease** coverage by `0.05%`.
> The diff coverage is `78.82%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/981?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #981 +/- ##
==========================================
- Coverage 78.99% 78.93% -0.06%
==========================================
Files 111 111
Lines 28422 28503 +81
==========================================
+ Hits 22451 22499 +48
- Misses 5971 6004 +33
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/981?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/adaptors/http1/http1\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NsaWVudC5j) | `68.03% <0.00%> (-1.91%)` | :arrow_down: |
| [src/adaptors/http2/http2\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAyL2h0dHAyX2FkYXB0b3IuYw==) | `2.94% <0.00%> (ø)` | |
| [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `3.09% <0.00%> (ø)` | |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.23% <0.00%> (+0.18%)` | :arrow_up: |
| [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.43% <57.14%> (-0.02%)` | :arrow_down: |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `86.84% <87.50%> (+0.19%)` | :arrow_up: |
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.95% <97.67%> (+0.16%)` | :arrow_up: |
| [src/adaptors/http\_common.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHBfY29tbW9uLmM=) | `80.00% <100.00%> (+0.58%)` | :arrow_up: |
| [src/router\_core/management\_agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21hbmFnZW1lbnRfYWdlbnQuYw==) | `97.60% <100.00%> (+0.02%)` | :arrow_up: |
| [src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=) | `92.17% <100.00%> (+0.01%)` | :arrow_up: |
| ... and [12 more](https://codecov.io/gh/apache/qpid-dispatch/pull/981/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/981?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/981?src=pr&el=footer). Last update [311f606...0ad9adc](https://codecov.io/gh/apache/qpid-dispatch/pull/981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] 4383 closed pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
4383 closed pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] 4383 edited a comment on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
4383 edited a comment on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-761065144
> I believe the original text is correct. Are you looking at the source directory structure or the installed directory structure? The documentation is referring to the installed artifacts.
As this is an example I was looking at the source directory.
I didn't try to build qpid-proton maybe I should have started by that :)
In this case it could be worth to indicate the build step in the documentation or to highlight that.
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
jiridanek edited a comment on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-762332562
I was thinking about changing the path in the sources to `examples/python`. Doing things this way would IMO make sense in the Dispatch repo, but not in the Proton repo. (Actually, the Proton repo used to be organized this way; it was later reorganized so that each language binding has its own top level directory.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] 4383 edited a comment on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
4383 edited a comment on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-761546347
I think you're right, the documentation is right, `__<install-dir>__` is explicit.
I'm going to close this PR.
Thanks for your time and thanks for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #981: [trivial] Fix path in doc examples
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #981:
URL: https://github.com/apache/qpid-dispatch/pull/981#issuecomment-762332562
I was thinking about changing the path in the sources to `examples/proton`. Doing things this way would IMO make sense in the Dispatch repo, but not in the Proton repo. (Actually, the Proton repo used to be organized this way; it was later reorganized so that each language binding has its own top level directory.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org