You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/02/27 17:49:31 UTC
Review Request 65817: Fixed argument quoting in the test script in
`HungDockerTest`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65817/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gilbert Song, and Greg Mann.
Repository: mesos
Description
-------
Previously, the command arguments for the command `docker $@` was
expanded by an interpreter into a string without quotes. So, a command
`docker run ... -c 'sleep 1'` was expanded into
`docker run ... -c sleep 1`. To fix the issue, `$@` has been wrapped
with double quotes.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp 9930580617b188b9c231b002d771e7ba4c61ac52
Diff: https://reviews.apache.org/r/65817/diff/1/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 65817: Fixed argument quoting in the test script in
`HungDockerTest`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65817/#review198339
-----------------------------------------------------------
PASS: Mesos patch 65817 was successfully built and tested.
Reviews applied: `['65817']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65817
- Mesos Reviewbot Windows
On Feb. 27, 2018, 5:49 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65817/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2018, 5:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the command arguments for the command `docker $@` was
> expanded by an interpreter into a string without quotes. So, a command
> `docker run ... -c 'sleep 1'` was expanded into
> `docker run ... -c sleep 1`. To fix the issue, `$@` has been wrapped
> with double quotes.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 9930580617b188b9c231b002d771e7ba4c61ac52
>
>
> Diff: https://reviews.apache.org/r/65817/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65817: Fixed argument quoting in the test script in
`HungDockerTest`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65817/#review198356
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 27, 2018, 5:49 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65817/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2018, 5:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the command arguments for the command `docker $@` was
> expanded by an interpreter into a string without quotes. So, a command
> `docker run ... -c 'sleep 1'` was expanded into
> `docker run ... -c sleep 1`. To fix the issue, `$@` has been wrapped
> with double quotes.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 9930580617b188b9c231b002d771e7ba4c61ac52
>
>
> Diff: https://reviews.apache.org/r/65817/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65817: Fixed argument quoting in the test script in
`HungDockerTest`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65817/#review198344
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65817]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2018, 5:49 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65817/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2018, 5:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gilbert Song, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the command arguments for the command `docker $@` was
> expanded by an interpreter into a string without quotes. So, a command
> `docker run ... -c 'sleep 1'` was expanded into
> `docker run ... -c sleep 1`. To fix the issue, `$@` has been wrapped
> with double quotes.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 9930580617b188b9c231b002d771e7ba4c61ac52
>
>
> Diff: https://reviews.apache.org/r/65817/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>