Re: [PR] fix(go/adbc/driver/snowflake): Made GetObjects case insensitive [arrow-adbc]

["ryan-syed (via GitHub)" <gi...@apache.org>]

ryan-syed commented on code in PR #1328:
URL: https://github.com/apache/arrow-adbc/pull/1328#discussion_r1412591687


##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -282,10 +282,10 @@ func (c *cnxn) getObjectsDbSchemas(ctx context.Context, depth adbc.ObjectDepth,
 
 	conditions := make([]string, 0)
 	if catalog != nil && *catalog != "" {
-		conditions = append(conditions, ` CATALOG_NAME LIKE '`+*catalog+`'`)
+		conditions = append(conditions, ` CATALOG_NAME ILIKE '`+*catalog+`'`)
 	}
 	if dbSchema != nil && *dbSchema != "" {
-		conditions = append(conditions, ` SCHEMA_NAME LIKE '`+*dbSchema+`'`)
+		conditions = append(conditions, ` SCHEMA_NAME ILIKE '`+*dbSchema+`'`)

Review Comment:
   I was looking at the existing tests in `driver_test.go` and they seemed like integration tests similar to what we have in `DriverTest.cs`. I am not sure if adding the same kind of test would add as much value. Is there a specific test that you had in mind, that I can draw inspiration from?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org